Should the minimal python version be 3.10?

[jmkuebler]

Hi folks, it seems that the minimal python version should be 3.10.
Otherwise I am getting a syntax error here
https://github.com/vllm-project/llm-compressor/blob/main/src/llmcompressor/modifiers/obcq/base.py#L122-L126

            with (
                torch.no_grad(),
                align_module_device(module),
                CompressionLogger(module) as comp_logger,
            ):

I got the error when running with python 3.8. Installing it in 3.10 it got resolved.

Or am I missing sth?

[kylesayrs]

Hi @jmkuebler

You are correct! Chained context managers were introduced by python3.10, this should be updated in the setup.py

[jmkuebler]

Thanks @kylesayrs, is it as simple as changing it in the setup.py?
#1251

[markurtz]

Weighing in here quickly with @rahul-tuli fix up on two main points for #1287 to ensure everyone is on the same page:

1. We have to support Python 3.9 until it is EOL in October. Anything prior to 3.9 can be safely ignored.
2. What was added with Python 3.10 was the ability to use parentheses in with statements. The offending lines need to escape to new lines utilizing backslashes or other clever techniques that don't involve wrapping the entire block in parentheses.