Skip to content

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Jul 15, 2025

Purpose

  • Enable quip-style transforms

Prerequisites

Changes

  • Added quip_example.py to examples folder
    • As made clear in the disclaimer, this example requires minimum versions of compressed-tensors and transformers to run
  • Added QuIPModifier which handles the construction of a quip-style transform config

Testing

  • Added modifier serialization and correctness tests

Evaluation

Evaluation performed by @brian-dellabetta

Evals on Llama 3.2 1B with Quip (num_fewshot 8, limit 1000 to be compatible with results here) :

Strat gsm8k,strict gsm8k_llama,strict
FP16 .352 .323
Quip .348 .322
W4A16 .180 .017
Quip+W4A16 .213 .141

Follow Ups

  • Infer data free pipeline, even if a transform modifier is included
  • Modify example to use GPTQ once basic evaluation has been performed

kylesayrs and others added 30 commits June 23, 2025 19:34
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Signed-off-by: Kyle Sayers <[email protected]>
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice - can we fix the example?

Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple comment/docstring requests

dsikka
dsikka previously approved these changes Aug 13, 2025
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Great work

@dsikka dsikka added the ready When a PR is ready for review label Aug 14, 2025
@dsikka dsikka enabled auto-merge (squash) August 14, 2025 19:35
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@dsikka dsikka disabled auto-merge August 14, 2025 20:18
@dsikka
Copy link
Collaborator

dsikka commented Aug 14, 2025

failed test related to an unrelated download failure - merging

@dsikka dsikka merged commit 6415131 into main Aug 14, 2025
12 of 13 checks passed
@dsikka dsikka deleted the kylesayrs/transform-quip-modifier branch August 14, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants