Bugfix/507 pp helm chart (#512)

* [Bugfix] Fixed wrong indentation number at ray cluster helm chart. Initial commit.

Signed-off-by: ahinsutime <[email protected]>

* [Bugfix] Added a script to test values for helm chart. Fixed additional typo in the helm chart.

Signed-off-by: ahinsutime <[email protected]>

---------

Signed-off-by: ahinsutime <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>

Author: ahinsutime

helm/Chart.yaml

@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.4
+version: 0.1.5
 
 maintainers:
   - name: apostac

helm/templates/ray-cluster.yaml

@@ -92,7 +92,7 @@ spec:
                 {{- end }}
               {{- end }}
               {{- with $modelSpec.env }}
-              {{- toYaml . | nindent 10 }}
+              {{- toYaml . | nindent 14 }}
               {{- end }}
               {{- if $modelSpec.lmcacheConfig }}
               {{-   if $modelSpec.lmcacheConfig.enabled }}
@@ -223,7 +223,7 @@ spec:
           {{- end }}
           {{- end}}
           {{- if hasKey $modelSpec "extraVolumes" }}
-          {{- toYaml $modelSpec.extraVolumes | nindent 8 }}
+          {{- toYaml $modelSpec.extraVolumes | nindent 10 }}
           {{- end}}
         {{- end}}
         {{- if $modelSpec.imagePullSecret }}
@@ -233,7 +233,7 @@ spec:
         {{- if .Values.servingEngineSpec.tolerations }}
         {{-   with .Values.servingEngineSpec.tolerations }}
         tolerations:
-          {{-   toYaml . | nindent 8 }}
+          {{-   toYaml . | nindent 10 }}
         {{-   end }}
         {{- end }}
         {{- if .Values.servingEngineSpec.runtimeClassName }}
@@ -250,7 +250,7 @@ spec:
             requiredDuringSchedulingIgnoredDuringExecution:
               nodeSelectorTerms:
               {{- with $modelSpec.nodeSelectorTerms }}
-              {{- toYaml . | nindent 12 }}
+              {{- toYaml . | nindent 14 }}
               {{- end }}
         {{- end }}
   workerGroupSpecs:
@@ -264,7 +264,7 @@ spec:
             helm-release-name: {{ .Release.Name }}
         {{- if .Values.servingEngineSpec.securityContext }}
         securityContext:
-          {{- toYaml .Values.servingEngineSpec.securityContext | nindent 8 }}
+          {{- toYaml .Values.servingEngineSpec.securityContext | nindent 10 }}
         {{- end }}
         spec:
           containers:
@@ -322,7 +322,7 @@ spec:
                   {{- end }}
                 {{- end }}
                 {{- with $modelSpec.env }}
-                {{- toYaml . | nindent 10 }}
+                {{- toYaml . | nindent 16 }}
                 {{- end }}
                 {{- if $modelSpec.lmcacheConfig }}
                 {{-   if $modelSpec.lmcacheConfig.enabled }}
@@ -431,7 +431,7 @@ spec:
             {{- end }}
             {{- end}}
             {{- if hasKey $modelSpec "extraVolumes" }}
-            {{- toYaml $modelSpec.extraVolumes | nindent 8 }}
+            {{- toYaml $modelSpec.extraVolumes | nindent 12 }}
             {{- end}}
           {{- end}}
           {{- if $modelSpec.imagePullSecret }}
@@ -441,7 +441,7 @@ spec:
           {{- if .Values.servingEngineSpec.tolerations }}
           {{-   with .Values.servingEngineSpec.tolerations }}
           tolerations:
-            {{-   toYaml . | nindent 8 }}
+            {{-   toYaml . | nindent 12 }}
           {{-   end }}
           {{- end }}
 
@@ -459,7 +459,7 @@ spec:
               requiredDuringSchedulingIgnoredDuringExecution:
                 nodeSelectorTerms:
                 {{- with $modelSpec.nodeSelectorTerms }}
-                {{- toYaml . | nindent 12 }}
+                {{- toYaml . | nindent 16 }}
                 {{- end }}
           {{- end }}
 

utils/helm-chart-test-values.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+set -e
+
+CHART_DIR="$1"
+VALUES_DIR="$2"
+
+if [[ -z "$CHART_DIR" || -z "$VALUES_DIR" ]]; then
+  echo "Usage: $0 <helm_chart_dir> <values_dir>"
+  exit 1
+fi
+
+if [[ ! -d "$CHART_DIR" || ! -d "$VALUES_DIR" ]]; then
+  echo "Error: Both arguments must be directories."
+  exit 1
+fi
+
+for values_file in "$VALUES_DIR"/values*.yaml; do
+  if [[ -f "$values_file" ]]; then
+    echo "🔍 Rendering with: $values_file"
+
+    if ! helm template my-release "$CHART_DIR" -f "$values_file" > /dev/null; then
+      echo "❌ Failed to render with $values_file" >&2
+    else
+      echo "✅ Success: $values_file"
+    fi
+  fi
+done