[Feat] Env from secret (#641)

* add doc/exemple

Signed-off-by: Redno2 <[email protected]>

* add endFrom secret

Signed-off-by: Redno2 <[email protected]>

* fix add endFrom secret

Signed-off-by: Redno2 <[email protected]>

* missing config for initContainer

Signed-off-by: Redno2 <[email protected]>

---------

Signed-off-by: Redno2 <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>

Author: redno2

helm/templates/deployment-vllm-multi.yaml

@@ -57,6 +57,11 @@ spec:
           {{- if $container.args }}
           args: {{ toYaml $container.args | nindent 12 }}
           {{- end }}
+          {{- if $modelSpec.envFromSecret }}
+          envFrom:
+            - secretRef:
+                name: {{ $modelSpec.envFromSecret.name }}
+          {{- end }}
           env:
             - name: RELEASE_NAME
               value: {{ $.Release.Name }}
@@ -333,11 +338,17 @@ spec:
             value: {{ $modelSpec.lmcacheConfig.workerPort | quote }}
           {{-   end }}
           {{- end }}
-          {{- if .Values.servingEngineSpec.configs }}
+          {{- if or .Values.servingEngineSpec.configs $modelSpec.envFromSecret }}
           envFrom:
+          {{- if .Values.servingEngineSpec.configs }}
             - configMapRef:
                 name: "{{ .Release.Name }}-configs"
           {{- end }}
+          {{- if $modelSpec.envFromSecret }}
+            - secretRef:
+                name: {{ $modelSpec.envFromSecret.name }}
+          {{- end }}
+          {{- end }}
           ports:
             - name: {{ include "chart.container-port-name" . }}
               containerPort: {{ include "chart.container-port" . }}

helm/values.yaml

@@ -90,6 +90,23 @@ servingEngineSpec:
   #     secretName: "my-existing-secret"
   #     secretKey: "hf-token-key"
   #
+  # - envFromSecret: (optional) Reference to an existing Kubernetes Secret from which
+  #   all key/value pairs will be loaded as environment variables into the container.
+  #   Example:
+  #     envFromSecret:
+  #       name: s3-registry
+  #
+  #   The referenced Secret could look like:
+  #     apiVersion: v1
+  #     kind: Secret
+  #     metadata:
+  #       name: s3-registry
+  #       namespace: vllm
+  #     data:
+  #       AWS_ACCESS_KEY_ID: <base64-encoded-value>
+  #       AWS_SECRET_ACCESS_KEY: <base64-encoded-value>
+  #       AWS_ENDPOINT_URL: <base64-encoded-value>
+  #
   # - env: (optional, list) The environment variables to set in the container, e.g., your HF_TOKEN
   #
   # - nodeSelectorTerms: (optional, list) The node selector terms to match the nodes