review feedback

Signed-off-by: Huamin Chen <[email protected]>

Author: rootfs

src/semantic-router/pkg/cache/comprehensive_benchmark_test.go

@@ -33,8 +33,8 @@ func (c ContentLength) String() string {
 // GenerateQuery generates a query with maximum semantic diversity using hash-based randomization
 func generateQuery(length ContentLength, index int) string {
 	// Hash the index to get pseudo-random values (deterministic but well-distributed)
-	hash := uint64(index)               // #nosec G115 -- index is always positive and bounded
-	hash = hash*2654435761 + 1013904223 // Knuth's multiplicative hash
+	hash := uint64(index)    // #nosec G115 -- index is always positive and bounded
+	hash = hash * 2654435761 // Knuth's multiplicative hash
 
 	// Expanded templates for maximum diversity
 	templates := []string{

src/semantic-router/pkg/cache/hybrid_cache.go

@@ -15,6 +15,14 @@ import (
 	"github.com/vllm-project/semantic-router/src/semantic-router/pkg/observability"
 )
 
+const (
+	// Buffer pool limits to prevent memory bloat
+	maxVisitedMapSize     = 1000 // Maximum size for visited map before discarding buffer
+	maxCandidatesCapacity = 200  // Maximum capacity for candidates heap before discarding buffer
+	maxResultsCapacity    = 200  // Maximum capacity for results heap before discarding buffer
+	maxHNSWLayers         = 16   // Maximum number of layers in HNSW index
+)
+
 // searchBuffers holds reusable buffers for HNSW search to reduce GC pressure
 type searchBuffers struct {
 	visited    map[int]bool
@@ -48,7 +56,7 @@ func getSearchBuffers() *searchBuffers {
 // putSearchBuffers returns buffers to pool
 func putSearchBuffers(buf *searchBuffers) {
 	// Don't return to pool if buffers grew too large (avoid memory bloat)
-	if len(buf.visited) > 1000 || cap(buf.candidates.data) > 200 || cap(buf.results.data) > 200 {
+	if len(buf.visited) > maxVisitedMapSize || cap(buf.candidates.data) > maxCandidatesCapacity || cap(buf.results.data) > maxResultsCapacity {
 		return
 	}
 	searchBufferPool.Put(buf)
@@ -782,7 +790,7 @@ func (h *HybridCache) selectLevelHybrid() int {
 	// Use exponential decay to select level
 	// Most nodes at layer 0, fewer at higher layers
 	level := 0
-	for level < 16 { // Max 16 layers
+	for level < maxHNSWLayers {
 		if randFloat() > h.hnswIndex.ml {
 			break
 		}

src/semantic-router/pkg/cache/hybrid_vs_milvus_benchmark_test.go

@@ -92,14 +92,15 @@ func (dcc *DatabaseCallCounter) Reset() {
 
 // getMilvusConfigPath returns the path to milvus.yaml config file
 func getMilvusConfigPath() string {
-	// Try absolute path first (for direct test execution)
-	configPath := "/home/ubuntu/rootfs/back/semantic-router.bak/config/cache/milvus.yaml"
-	if _, err := os.Stat(configPath); err == nil {
-		return configPath
+	// Check for environment variable first
+	if envPath := os.Getenv("MILVUS_CONFIG_PATH"); envPath != "" {
+		if _, err := os.Stat(envPath); err == nil {
+			return envPath
+		}
 	}
 
 	// Try relative from project root (when run via make)
-	configPath = "config/cache/milvus.yaml"
+	configPath := "config/cache/milvus.yaml"
 	if _, err := os.Stat(configPath); err == nil {
 		return configPath
 	}
@@ -126,10 +127,16 @@ func BenchmarkHybridVsMilvus(b *testing.B) {
 	}
 
 	// CSV output file - save to project benchmark_results directory
-	// Determine project root by walking up from test directory
-	projectRoot := "/home/ubuntu/rootfs/back/semantic-router.bak"
-	if envRoot := os.Getenv("PROJECT_ROOT"); envRoot != "" {
-		projectRoot = envRoot
+	// Use PROJECT_ROOT environment variable, fallback to working directory
+	projectRoot := os.Getenv("PROJECT_ROOT")
+	if projectRoot == "" {
+		// If not set, use current working directory
+		var err error
+		projectRoot, err = os.Getwd()
+		if err != nil {
+			b.Logf("Warning: Could not determine working directory: %v", err)
+			projectRoot = "."
+		}
 	}
 	resultsDir := filepath.Join(projectRoot, "benchmark_results", "hybrid_vs_milvus")
 	os.MkdirAll(resultsDir, 0755)