Skip to content

Commit 2bdfc9d

Browse files
committed
fix:make reasoning effort configurable
Signed-off-by: OneZero-Y <[email protected]>
1 parent 9ea35b8 commit 2bdfc9d

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

src/semantic-router/pkg/extproc/reason_mode_selector.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,7 @@ func getChatTemplateKwargs(model string, useReasoning bool) map[string]interface
6363
}
6464
}
6565

66-
// Default: use thinking for all other models when reasoning is enabled
67-
if useReasoning {
68-
return map[string]interface{}{
69-
"thinking": useReasoning,
70-
}
71-
}
72-
73-
// No chat template kwargs when reasoning is disabled
66+
// Default: no chat template kwargs for unknown models
7467
return nil
7568
}
7669

src/semantic-router/pkg/extproc/reasoning_integration_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ func TestReasoningModeIntegration(t *testing.T) {
148148
// But reasoning_effort should still be set
149149
if reasoningEffort, exists := modifiedRequestPhi4["reasoning_effort"]; !exists {
150150
t.Error("reasoning_effort should be set for phi4 model")
151-
} else if reasoningEffort != "high" {
152-
t.Errorf("Expected reasoning_effort: high for phi4 model, got %v", reasoningEffort)
151+
} else if reasoningEffort != "medium" {
152+
t.Errorf("Expected reasoning_effort: medium for phi4 model (default), got %v", reasoningEffort)
153153
}
154154
})
155155

0 commit comments

Comments
 (0)