lint

Signed-off-by: bitliu <[email protected]>

Author: Xunzhuo

src/semantic-router/pkg/cache/cache_test.go

@@ -1734,7 +1734,9 @@ func BenchmarkHybridVsMilvus(b *testing.B) {
 		}
 	}
 	resultsDir := filepath.Join(projectRoot, "benchmark_results", "hybrid_vs_milvus")
-	os.MkdirAll(resultsDir, 0755)
+	if err := os.MkdirAll(resultsDir, 0755); err != nil {
+		b.Logf("Warning: Could not create results directory: %v", err)
+	}
 	timestamp := time.Now().Format("20060102_150405")
 	csvPath := filepath.Join(resultsDir, fmt.Sprintf("results_%s.csv", timestamp))
 	csvFile, err := os.Create(csvPath)
@@ -1744,7 +1746,9 @@ func BenchmarkHybridVsMilvus(b *testing.B) {
 		defer csvFile.Close()
 		b.Logf("Results will be saved to: %s", csvPath)
 		// Write CSV header
-		csvFile.WriteString("cache_type,cache_size,operation,avg_latency_ns,avg_latency_ms,p50_ms,p95_ms,p99_ms,qps,memory_mb,hit_rate,db_calls,total_requests,db_call_percent\n")
+		if _, err := csvFile.WriteString("cache_type,cache_size,operation,avg_latency_ns,avg_latency_ms,p50_ms,p95_ms,p99_ms,qps,memory_mb,hit_rate,db_calls,total_requests,db_call_percent\n"); err != nil {
+			b.Logf("Warning: Could not write CSV header: %v", err)
+		}
 	}
 
 	b.Logf("=== Hybrid Cache vs Pure Milvus Benchmark ===")
@@ -2174,7 +2178,7 @@ func BenchmarkComponentLatency(b *testing.B) {
 
 		b.Logf("Building HNSW index with %d entries...", cacheSize)
 		for i := 0; i < cacheSize; i++ {
-			cache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
+			_ = cache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
 		}
 		b.Logf("✓ HNSW index built")
 
@@ -2184,7 +2188,7 @@ func BenchmarkComponentLatency(b *testing.B) {
 		start := time.Now()
 		for i := 0; i < b.N; i++ {
 			// Note: HNSW search uses entries slice internally
-			cache.FindSimilar("model", query)
+			_, _, _ = cache.FindSimilar("model", query)
 		}
 		elapsed := time.Since(start)
 		avgMs := float64(elapsed.Nanoseconds()) / float64(b.N) / 1e6
@@ -2208,7 +2212,7 @@ func BenchmarkComponentLatency(b *testing.B) {
 
 		b.Logf("Populating Milvus with %d entries...", cacheSize)
 		for i := 0; i < cacheSize; i++ {
-			milvusCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
+			_ = milvusCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
 		}
 		time.Sleep(2 * time.Second)
 		b.Logf("✓ Milvus populated")
@@ -2218,7 +2222,7 @@ func BenchmarkComponentLatency(b *testing.B) {
 		b.ResetTimer()
 		start := time.Now()
 		for i := 0; i < b.N; i++ {
-			milvusCache.FindSimilar("model", query)
+			_, _, _ = milvusCache.FindSimilar("model", query)
 		}
 		elapsed := time.Since(start)
 		avgMs := float64(elapsed.Nanoseconds()) / float64(b.N) / 1e6
@@ -2266,7 +2270,7 @@ func BenchmarkThroughputUnderLoad(b *testing.B) {
 
 			// Populate
 			for i := 0; i < cacheSize; i++ {
-				milvusCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
+				_ = milvusCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
 			}
 			time.Sleep(2 * time.Second)
 
@@ -2278,7 +2282,7 @@ func BenchmarkThroughputUnderLoad(b *testing.B) {
 				i := 0
 				for pb.Next() {
 					query := testQueries[i%len(testQueries)]
-					milvusCache.FindSimilar("model", query)
+					_, _, _ = milvusCache.FindSimilar("model", query)
 					i++
 				}
 			})
@@ -2308,7 +2312,7 @@ func BenchmarkThroughputUnderLoad(b *testing.B) {
 
 			// Populate
 			for i := 0; i < cacheSize; i++ {
-				hybridCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
+				_ = hybridCache.AddEntry(fmt.Sprintf("req-%d", i), "model", testQueries[i], []byte("req"), []byte("resp"))
 			}
 			time.Sleep(2 * time.Second)
 
@@ -2320,7 +2324,7 @@ func BenchmarkThroughputUnderLoad(b *testing.B) {
 				i := 0
 				for pb.Next() {
 					query := testQueries[i%len(testQueries)]
-					hybridCache.FindSimilar("model", query)
+					_, _, _ = hybridCache.FindSimilar("model", query)
 					i++
 				}
 			})
@@ -2374,7 +2378,10 @@ func writeBenchmarkResultToCSV(file *os.File, result BenchmarkResult) {
 		result.TotalRequests,
 		result.DatabaseCallPercent,
 	)
-	file.WriteString(line)
+	if _, err := file.WriteString(line); err != nil {
+		// Ignore write errors in benchmark helper
+		_ = err
+	}
 }
 
 // TestHybridVsMilvusSmoke is a quick smoke test to verify both caches work

src/semantic-router/pkg/extproc/stream_handling_test.go

@@ -17,12 +17,12 @@ import (
 	. "github.com/onsi/gomega"
 	"github.com/openai/openai-go"
 	"github.com/prometheus/client_golang/prometheus"
+	dto "github.com/prometheus/client_model/go"
 	"github.com/stretchr/testify/assert"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
 
-	dto "github.com/prometheus/client_model/go"
 	candle_binding "github.com/vllm-project/semantic-router/candle-binding"
 	"github.com/vllm-project/semantic-router/src/semantic-router/pkg/cache"
 	"github.com/vllm-project/semantic-router/src/semantic-router/pkg/classification"

src/semantic-router/pkg/extproc/utils.go

@@ -2,6 +2,7 @@ package extproc
 
 import (
 	ext_proc "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
+
 	"github.com/vllm-project/semantic-router/src/semantic-router/pkg/observability/logging"
 )