fix

Signed-off-by: yuluo-yx <[email protected]>

Author: yuluo-yx

Dockerfile.precommit

@@ -15,8 +15,8 @@ RUN curl -fsSL https://deb.nodesource.com/setup_lts.x | bash - && \
     apt-get install -y nodejs
 
 # Install Rust
-RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \
-    . $HOME/.cargo/env
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ENV PATH="/root/.cargo/bin:${PATH}"
 
 # Markdown
 RUN npm install -g markdownlint-cli

tools/make/pre-commit.mk

@@ -23,16 +23,21 @@ precommit-check:
 
 # Run pre-commit hooks in a Docker container
 # and you can exec container to run bash for debug.
+# export PRECOMMIT_CONTAINER=ghcr.io/vllm-project/semantic-router/precommit:latest
 # docker run --rm -it \
-#		-v $(shell pwd):/app \
-#		--name precommit-container ${PRECOMMIT_CONTAINER} \
-#		cd /app &&
-#		bash
+#     -v $(pwd):/app \
+#     -w /app \
+#     --name precommit-container ${PRECOMMIT_CONTAINER} \
+#     bash
 precommit-local:
-	docker pull ${PRECOMMIT_CONTAINER}
+	@if ! docker image inspect ${PRECOMMIT_CONTAINER} > /dev/null 2>&1; then \
+		echo "Image not found locally. Pulling..."; \
+		docker pull ${PRECOMMIT_CONTAINER}; \
+	else \
+		echo "Image found locally. Skipping pull."; \
+	fi
 	docker run --rm \
-		-v $(pwd):/app \
-		--name precommit-container ${PRECOMMIT_CONTAINER}
-		cd /app && \
-		pre-commit install && \
-		pre-commit run --all-files
+	    -v $(pwd):/app \
+	    -w /app \
+	    --name precommit-container ${PRECOMMIT_CONTAINER} \
+	    bash -c " pre-commit install && pre-commit run --all-files"