Skip to content

Commit 4a29c4b

Browse files
yossiovadiaclaude
andcommitted
fix: remove log tail limit in validation script for model loading detection
The validation script was failing to detect successful model loading because it used --tail=200 to check container logs. Since model containers generate many health check logs after startup, the "model loaded" messages were beyond the 200-line limit. Changes: - Remove --tail=200 from model-a validation (line 98) - Remove --tail=200 from model-b validation (line 110) - Now scans entire log history for "model loaded" message Fixes #391 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Yossi Ovadia <[email protected]>
1 parent ea0c6ea commit 4a29c4b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deploy/openshift/validate-deployment.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ fi
9595
# Test 6: Check model-a loaded successfully
9696
log "INFO" "Test 6: Checking model-a loaded successfully..."
9797
if [[ -n "$POD_NAME" ]]; then
98-
MODEL_STATUS=$(oc logs -n "$NAMESPACE" "$POD_NAME" -c model-a --tail=200 | grep -i "model loaded" | tail -1)
98+
MODEL_STATUS=$(oc logs -n "$NAMESPACE" "$POD_NAME" -c model-a | grep -i "model loaded" | tail -1)
9999
if [[ -n "$MODEL_STATUS" ]]; then
100100
DEVICE=$(echo "$MODEL_STATUS" | grep -oE "(cuda|cpu)" || echo "unknown")
101101
log "PASS" "Model-A loaded successfully on $DEVICE"
@@ -107,7 +107,7 @@ fi
107107
# Test 7: Check model-b loaded successfully
108108
log "INFO" "Test 7: Checking model-b loaded successfully..."
109109
if [[ -n "$POD_NAME" ]]; then
110-
MODEL_STATUS=$(oc logs -n "$NAMESPACE" "$POD_NAME" -c model-b --tail=200 | grep -i "model loaded" | tail -1)
110+
MODEL_STATUS=$(oc logs -n "$NAMESPACE" "$POD_NAME" -c model-b | grep -i "model loaded" | tail -1)
111111
if [[ -n "$MODEL_STATUS" ]]; then
112112
DEVICE=$(echo "$MODEL_STATUS" | grep -oE "(cuda|cpu)" || echo "unknown")
113113
log "PASS" "Model-B loaded successfully on $DEVICE"

0 commit comments

Comments
 (0)