refactor: use slices.Contains for readability and consistency (#104)

Signed-off-by: cryo <[email protected]>

Author: cryo-zd

src/semantic-router/pkg/config/config.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"slices"
 	"sync"
 
 	"gopkg.in/yaml.v3"
@@ -439,14 +440,7 @@ func (c *RouterConfig) IsModelAllowedForPIIType(modelName string, piiType string
 	}
 
 	// If allow_by_default is false, only explicitly allowed PII types are permitted
-	for _, allowedPII := range policy.PIITypes {
-		if allowedPII == piiType {
-			return true
-		}
-	}
-
-	// PII type not found in allowed list and allow_by_default is false
-	return false
+	return slices.Contains(policy.PIITypes, piiType)
 }
 
 // IsModelAllowedForPIITypes checks if a model is allowed to process any of the given PII types
@@ -487,23 +481,17 @@ func (c *RouterConfig) GetEndpointsForModel(modelName string) []VLLMEndpoint {
 
 	// First, find all endpoints that can serve this model
 	for _, endpoint := range c.VLLMEndpoints {
-		for _, model := range endpoint.Models {
-			if model == modelName {
-				availableEndpoints = append(availableEndpoints, endpoint)
-				break
-			}
+		if slices.Contains(endpoint.Models, modelName) {
+			availableEndpoints = append(availableEndpoints, endpoint)
 		}
 	}
 
 	// Check if model has preferred endpoints configured
 	if modelConfig, ok := c.ModelConfig[modelName]; ok && len(modelConfig.PreferredEndpoints) > 0 {
 		var preferredEndpoints []VLLMEndpoint
 		for _, endpoint := range availableEndpoints {
-			for _, preferredName := range modelConfig.PreferredEndpoints {
-				if endpoint.Name == preferredName {
-					preferredEndpoints = append(preferredEndpoints, endpoint)
-					break
-				}
+			if slices.Contains(modelConfig.PreferredEndpoints, endpoint.Name) {
+				preferredEndpoints = append(preferredEndpoints, endpoint)
 			}
 		}
 		if len(preferredEndpoints) > 0 {

src/semantic-router/pkg/utils/pii/policy.go

@@ -2,6 +2,7 @@ package pii
 
 import (
 	"log"
+	"slices"
 
 	"github.com/vllm-project/semantic-router/semantic-router/pkg/config"
 )
@@ -59,14 +60,7 @@ func (pc *PolicyChecker) CheckPolicy(model string, detectedPII []string) (bool,
 		}
 
 		// If allow_by_default is false, check if this PII type is explicitly allowed
-		isAllowed := false
-		for _, allowedPII := range policy.PIITypes {
-			if allowedPII == piiType {
-				isAllowed = true
-				break
-			}
-		}
-
+		isAllowed := slices.Contains(policy.PIITypes, piiType)
 		if !isAllowed {
 			deniedPII = append(deniedPII, piiType)
 		}