Skip to content

Commit 76db897

Browse files
committed
fix(e2e): remove invalid 'always' signal type from CRD
The previous attempt to add a default catch-all decision used type="always" which is not a valid signal condition type. Valid types are only: keyword, embedding, domain. Root cause analysis reveals a deeper issue: PII E2E tests use model="MoM" which triggers domain classification, but the test data is domain-agnostic (contains PII like SSN, names without domain context), so no domain matches, no decision is selected, and PII detection is disabled. This is a fundamental test design issue that requires discussion. Signed-off-by: Yossi Ovadia <[email protected]>
1 parent af7dfcd commit 76db897

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

e2e/profiles/dynamic-config/crds/intelligentroute.yaml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -344,20 +344,3 @@ spec:
344344
enabled: true
345345
system_prompt: "You are an engineering expert with knowledge across multiple engineering disciplines including mechanical, electrical, civil, chemical, software, and systems engineering. Apply engineering principles, design methodologies, and problem-solving approaches to provide practical solutions. Consider safety, efficiency, sustainability, and cost-effectiveness in your recommendations. Use technical precision while explaining concepts clearly, and emphasize the importance of proper engineering practices and standards."
346346
mode: "replace"
347-
348-
- name: "default_decision"
349-
priority: 1
350-
description: "Default catch-all decision - blocks all PII for safety"
351-
signals:
352-
operator: "OR"
353-
conditions:
354-
- type: "always"
355-
modelRefs:
356-
- model: "base-model"
357-
loraName: "science-expert"
358-
useReasoning: false
359-
plugins:
360-
- type: "pii"
361-
configuration:
362-
enabled: true
363-
pii_types_allowed: []

0 commit comments

Comments
 (0)