[CI] refactor helm publish workflow fix PR test error (#762)

Signed-off-by: samzong <[email protected]>

Author: samzong

.github/workflows/helm-publish.yml

@@ -5,12 +5,12 @@ on:
     branches:
       - main
     paths:
-      - 'deploy/helm/**'
+      - "deploy/helm/**"
   push:
     branches:
       - main
     paths:
-      - 'deploy/helm/**'
+      - "deploy/helm/**"
   workflow_dispatch:
 
 env:
@@ -20,73 +20,60 @@ env:
   CHART_NAME: semantic-router
 
 jobs:
-  publish-chart:
-    name: Publish Helm Chart to GHCR
+  validate-and-package:
+    name: Validate and Package
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      packages: write
+    outputs:
+      chart-name: ${{ steps.package.outputs.name }}
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Set up Helm
-        uses: azure/setup-helm@v4
+      - uses: actions/checkout@v4
+      - uses: azure/setup-helm@v4
         with:
           version: ${{ env.HELM_VERSION }}
 
-      - name: Set lowercase repository owner
-        run: echo "REPOSITORY_OWNER_LOWER=$(echo $GITHUB_REPOSITORY_OWNER | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV
-
-      - name: Log in to GitHub Container Registry
-        run: |
-          echo "${{ secrets.GITHUB_TOKEN }}" | helm registry login ${{ env.REGISTRY }} --username ${{ github.actor }} --password-stdin
-
-      - name: Modify chart version to latest
-        run: |
-          echo "::group::Modify Chart.yaml"
-          # Backup original Chart.yaml
-          cp ${{ env.CHART_PATH }}/Chart.yaml ${{ env.CHART_PATH }}/Chart.yaml.bak
-
-          # Replace version with 'v0.0.0-latest' (valid semver with prerelease tag)
-          sed -i 's/^version:.*/version: v0.0.0-latest/' ${{ env.CHART_PATH }}/Chart.yaml
-
-          echo "Modified Chart.yaml:"
-          grep '^version:' ${{ env.CHART_PATH }}/Chart.yaml
-          echo "::endgroup::"
-
-      - name: Package Helm chart
-        run: |
-          echo "::group::Package Chart"
-          mkdir -p ./dist
-          helm package ${{ env.CHART_PATH }} --destination ./dist
-          echo "::endgroup::"
-
-          echo "::group::Packaged Chart"
-          ls -lh ./dist/
-          echo "::endgroup::"
+      - name: Lint chart
+        run: helm lint ${{ env.CHART_PATH }}
 
-      - name: Push chart to GHCR
+      - name: Package chart
+        id: package
         run: |
-          echo "::group::Push to GHCR"
-          CHART_PACKAGE="./dist/${{ env.CHART_NAME }}-v0.0.0-latest.tgz"
+          helm package ${{ env.CHART_PATH }} --version v0.0.0-latest --destination .
+          echo "name=$(ls *.tgz)" >> $GITHUB_OUTPUT
 
-          # Push to GHCR using OCI format with v0.0.0-latest tag
-          helm push "${CHART_PACKAGE}" oci://${{ env.REGISTRY }}/${{ env.REPOSITORY_OWNER_LOWER }}/charts
+      - name: Upload packaged chart
+        if: github.event_name != 'pull_request'
+        uses: actions/upload-artifact@v4
+        with:
+          name: helm-chart
+          path: "*.tgz"
+          retention-days: 1
 
-          echo "::endgroup::"
+  publish-chart:
+    name: Publish to GHCR
+    runs-on: ubuntu-latest
+    if: github.event_name != 'pull_request'
+    needs: validate-and-package
+    permissions:
+      packages: write
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: helm-chart
 
-          echo "✓ Chart published successfully!"
-          echo "Chart: ${{ env.REGISTRY }}/${{ env.REPOSITORY_OWNER_LOWER }}/charts/${{ env.CHART_NAME }}:v0.0.0-latest"
+      - uses: azure/setup-helm@v4
+        with:
+          version: ${{ env.HELM_VERSION }}
 
-      - name: Restore original Chart.yaml
-        if: always()
+      - name: Publish chart
+        env:
+          CHART: ${{ needs.validate-and-package.outputs.chart-name }}
+          REPO: ${{ env.REGISTRY }}/$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]')/charts
         run: |
-          # Restore original Chart.yaml
-          if [ -f "${{ env.CHART_PATH }}/Chart.yaml.bak" ]; then
-            mv ${{ env.CHART_PATH }}/Chart.yaml.bak ${{ env.CHART_PATH }}/Chart.yaml
-            echo "Chart.yaml restored"
-          fi
+          echo "${{ secrets.GITHUB_TOKEN }}" | helm registry login ${{ env.REGISTRY }} -u ${{ github.actor }} --password-stdin
+          helm push "$CHART" "oci://$REPO"
+          helm registry logout ${{ env.REGISTRY }}
 
       - name: Create release summary
         run: |
@@ -118,9 +105,3 @@ jobs:
             --namespace vllm-semantic-router-system
           \`\`\`
           EOF
-
-      - name: Logout from registry
-        if: always()
-        run: |
-          helm registry logout ${{ env.REGISTRY }} || true
-