Skip to content

Commit 9b591f1

Browse files
yossiovadiaclaude
andcommitted
cleanup: simplify status report and remove redundant 503 comments
- Simplified TEST_STATUS_REPORT.md to focus only on current system issues - Remove resolved/fixed sections that are no longer relevant - Replace (200, 200) ranges with simple 200 expected status in error handling - Remove redundant 'no 503 accepted' comments from all test files - Clean up unnecessary verbosity while maintaining test functionality Co-Authored-By: Claude <[email protected]> Signed-off-by: Yossi Ovadia <[email protected]>
1 parent cb2344b commit 9b591f1

File tree

6 files changed

+29
-250
lines changed

6 files changed

+29
-250
lines changed

e2e-tests/03-jailbreak-test.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,7 @@ def test_benign_requests_allowed(self):
164164
timeout=(10, 60), # (connect timeout, read timeout)
165165
)
166166

167-
# Benign requests should be processed successfully - no 503 accepted
168-
# If jailbreak detection is working, benign requests must get through with 200
167+
# Benign requests should be processed successfully
169168
passed = response.status_code == 200
170169

171170
try:

e2e-tests/05-pii-policy-test.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,7 @@ def test_no_pii_requests_allowed(self):
198198
timeout=(10, 60), # (connect timeout, read timeout)
199199
)
200200

201-
# No PII requests should be processed successfully - no 503 accepted
202-
# If PII detection is working, no-PII requests must succeed with 200
201+
# No PII requests should be processed successfully
203202
passed = response.status_code == 200
204203

205204
try:
@@ -271,8 +270,7 @@ def test_allowed_pii_requests(self):
271270
timeout=(10, 60), # (connect timeout, read timeout)
272271
)
273272

274-
# Allowed PII requests should be processed successfully - no 503 accepted
275-
# If PII detection is working, allowed PII requests must succeed with 200
273+
# Allowed PII requests should be processed successfully
276274
passed = response.status_code == 200
277275

278276
try:
@@ -485,8 +483,7 @@ def test_model_pii_policy_configuration(self):
485483
},
486484
)
487485

488-
# The request should be processed successfully - no 503 accepted
489-
# If PII policy is working, allowed PII types must succeed with 200
486+
# The request should be processed successfully
490487
passed = response.status_code == 200
491488
self.print_test_result(
492489
passed=passed,

e2e-tests/06-tools-test.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,7 @@ def test_specific_tool_selection(self):
187187
)
188188

189189
# Tool selection should work regardless of vLLM backend availability
190-
# Tool selection should work successfully - no 503 accepted
191-
# If tool selection is working, requests must succeed with 200
190+
# Tool selection should work successfully
192191
passed = response.status_code == 200
193192

194193
try:
@@ -264,8 +263,7 @@ def test_no_tool_requests(self):
264263
timeout=30,
265264
)
266265

267-
# Tool selection should work successfully - no 503 accepted
268-
# If tool selection is working, requests must succeed with 200
266+
# Tool selection should work successfully
269267
passed = response.status_code == 200
270268

271269
try:

e2e-tests/07-model-selection-test.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,7 @@ def test_category_based_model_selection(self):
217217
timeout=30,
218218
)
219219

220-
# Model selection should work successfully - no 503 accepted
221-
# If model selection is working, requests must succeed with 200
220+
# Model selection should work successfully
222221
passed = response.status_code == 200
223222

224223
try:
@@ -298,8 +297,7 @@ def test_reasoning_mode_selection(self):
298297
timeout=30,
299298
)
300299

301-
# Reasoning mode should work successfully - no 503 accepted
302-
# If reasoning mode selection is working, requests must succeed with 200
300+
# Reasoning mode should work successfully
303301
passed = response.status_code == 200
304302

305303
try:
@@ -373,7 +371,6 @@ def test_model_fallback_behavior(self):
373371
)
374372

375373
# Fallback should work - 400 is acceptable for invalid model request
376-
# No 503 accepted - if fallback is working, it should handle gracefully
377374
passed = response.status_code in [200, 400] # 400 is acceptable for invalid model
378375

379376
try:

e2e-tests/09-error-handling-test.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
for i in range(100) # 100 messages
111111
],
112112
},
113-
"expected_status_range": (200, 200), # Must be processed successfully - no 503 accepted
113+
"expected_status": 200,
114114
"description": "Large number of messages should be handled",
115115
},
116116
{
@@ -121,7 +121,7 @@
121121
{"role": "user", "content": "Hello 世界 🌍 Здравствуй мир"}
122122
],
123123
},
124-
"expected_status_range": (200, 200), # Must be processed successfully - no 503 accepted
124+
"expected_status": 200,
125125
"description": "Unicode characters should be handled correctly",
126126
},
127127
{
@@ -131,7 +131,7 @@
131131
"messages": [{"role": "user", "content": "Hello"}],
132132
"temperature": 0,
133133
},
134-
"expected_status_range": (200, 200), # Must be processed successfully - no 503 accepted
134+
"expected_status": 200,
135135
"description": "Zero temperature should be valid",
136136
},
137137
{
@@ -141,7 +141,7 @@
141141
"messages": [{"role": "user", "content": "Hello"}],
142142
"temperature": 2.0,
143143
},
144-
"expected_status_range": (200, 200), # Must be processed successfully - no 503 accepted
144+
"expected_status": 200,
145145
"description": "Maximum valid temperature should work",
146146
},
147147
{
@@ -152,7 +152,7 @@
152152
{"role": "user", "content": "Test with \"quotes\" and 'apostrophes' and \n newlines \t tabs"}
153153
],
154154
},
155-
"expected_status_range": (200, 200), # Must be processed successfully - no 503 accepted
155+
"expected_status": 200,
156156
"description": "Special characters should be handled",
157157
},
158158
]
@@ -247,8 +247,8 @@ def test_malformed_requests(self):
247247
timeout=30,
248248
)
249249

250-
min_status, max_status = test_case["expected_status_range"]
251-
passed = min_status <= response.status_code <= max_status
250+
expected_status = test_case["expected_status"]
251+
passed = response.status_code == expected_status
252252

253253
try:
254254
response_json = response.json()
@@ -260,7 +260,7 @@ def test_malformed_requests(self):
260260
response,
261261
{
262262
"Payload": str(test_case["payload"])[:100] + "...",
263-
"Expected Range": f"{min_status}-{max_status}",
263+
"Expected Status": expected_status,
264264
"Actual Status": response.status_code,
265265
"Error Info": str(error_info)[:100] + "..." if len(str(error_info)) > 100 else str(error_info),
266266
"Session ID": session_id,
@@ -273,14 +273,14 @@ def test_malformed_requests(self):
273273
message=(
274274
f"Malformed request properly rejected (status: {response.status_code})"
275275
if passed
276-
else f"Unexpected status code: {response.status_code} (expected {min_status}-{max_status})"
276+
else f"Unexpected status code: {response.status_code} (expected {expected_status})"
277277
),
278278
)
279279

280280
self.assertTrue(
281281
passed,
282282
f"Malformed request '{test_case['name']}' returned status {response.status_code}, "
283-
f"expected {min_status}-{max_status}",
283+
f"expected {expected_status}",
284284
)
285285

286286
def test_edge_cases(self):
@@ -302,7 +302,7 @@ def test_edge_cases(self):
302302

303303
self.print_request_info(
304304
payload={**test_case["payload"], "messages": [{"content": f"[{len(str(test_case['payload']['messages']))} chars]"}]}, # Show length instead of full content
305-
expectations=f"Expect: {test_case['expected_status_range'][0]}-{test_case['expected_status_range'][1]} status code",
305+
expectations=f"Expect: {test_case['expected_status']} status code",
306306
)
307307

308308
response = requests.post(
@@ -312,8 +312,8 @@ def test_edge_cases(self):
312312
timeout=30, # Longer timeout for edge cases
313313
)
314314

315-
min_status, max_status = test_case["expected_status_range"]
316-
passed = min_status <= response.status_code <= max_status
315+
expected_status = test_case["expected_status"]
316+
passed = response.status_code == expected_status
317317

318318
try:
319319
response_json = response.json()
@@ -325,7 +325,7 @@ def test_edge_cases(self):
325325
response,
326326
{
327327
"Test Case": test_case["name"],
328-
"Expected Range": f"{min_status}-{max_status}",
328+
"Expected Status": expected_status,
329329
"Actual Status": response.status_code,
330330
"Selected Model": model,
331331
"Session ID": session_id,
@@ -345,7 +345,7 @@ def test_edge_cases(self):
345345
self.assertTrue(
346346
passed,
347347
f"Edge case '{test_case['name']}' returned status {response.status_code}, "
348-
f"expected {min_status}-{max_status}",
348+
f"expected {expected_status}",
349349
)
350350

351351
def test_timeout_handling(self):

0 commit comments

Comments
 (0)