Skip to content

Commit b0dfb6a

Browse files
committed
Fix CI failures: remove unused helpers and disable CUDA
This commit fixes two CI failures: 1. Removed unused pointer helper functions (boolPtr, stringPtr, int64Ptr, float64Ptr) that were flagged by golangci-lint as unused 2. Disabled CUDA feature for Rust candle-binding builds in CI by adding --no-default-features flag to cargo build commands, since CI runners don't have CUDA/nvcc installed All 35 tests still pass locally after these changes. Signed-off-by: szedan
1 parent 4d6b073 commit b0dfb6a

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

.github/workflows/unit-test-e2e-testcases.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
- name: Build Rust Candle Bindings
5555
run: |
5656
cd candle-binding
57-
cargo build --release
57+
cargo build --release --no-default-features
5858
ls -la target/release/
5959
6060
- name: Verify Rust library
@@ -157,7 +157,7 @@ jobs:
157157
- name: Build Rust Candle Bindings
158158
run: |
159159
cd candle-binding
160-
cargo build --release
160+
cargo build --release --no-default-features
161161
162162
- name: Run Embedding Routing Tests
163163
env:
@@ -197,7 +197,7 @@ jobs:
197197
- name: Build Rust Candle Bindings
198198
run: |
199199
cd candle-binding
200-
cargo build --release
200+
cargo build --release --no-default-features
201201
202202
- name: Run Hybrid Routing Tests
203203
env:
@@ -233,7 +233,7 @@ jobs:
233233
- name: Build Rust Candle Bindings
234234
run: |
235235
cd candle-binding
236-
cargo build --release
236+
cargo build --release --no-default-features
237237
238238
- name: Run tests with race detector
239239
env:

e2e-tests/testcases/helpers.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -161,23 +161,3 @@ func CreateKeywordTestRules() []config.KeywordRule {
161161
func CreateTestKeywordClassifier(rules []config.KeywordRule) (*classification.KeywordClassifier, error) {
162162
return classification.NewKeywordClassifier(rules)
163163
}
164-
165-
// boolPtr is a helper to create *bool for config fields
166-
func boolPtr(b bool) *bool {
167-
return &b
168-
}
169-
170-
// stringPtr is a helper to create *string for config fields
171-
func stringPtr(s string) *string {
172-
return &s
173-
}
174-
175-
// int64Ptr is a helper to create *int64 for config fields
176-
func int64Ptr(i int64) *int64 {
177-
return &i
178-
}
179-
180-
// float64Ptr is a helper to create *float64 for config fields
181-
func float64Ptr(f float64) *float64 {
182-
return &f
183-
}

0 commit comments

Comments
 (0)