Skip to content

Commit b231ed0

Browse files
committed
fix: make PR comment step optional in performance workflow
The PR comment step can fail when running on pull requests from forks due to GitHub's security restrictions. Even with write permissions specified, GITHUB_TOKEN is read-only for fork PRs to prevent malicious code from writing to the base repository. Added 'continue-on-error: true' to make this step optional. The performance results will still be available in the workflow artifacts even if commenting fails. Fixes the '403 Resource not accessible by integration' error on fork PRs. Signed-off-by: Senan Zedan <[email protected]>
1 parent fcedc2b commit b231ed0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/performance-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ jobs:
127127
128128
- name: Comment PR with results
129129
if: github.event_name == 'pull_request'
130+
continue-on-error: true # May fail for PRs from forks due to GitHub security restrictions
130131
uses: actions/github-script@v7
131132
with:
132133
script: |

0 commit comments

Comments
 (0)