Skip to content

Commit b60a085

Browse files
committed
fix: disable pii checker by prompt guard knob
Signed-off-by: bitliu <[email protected]>
1 parent bbb5543 commit b60a085

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

src/semantic-router/pkg/extproc/router.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func NewOpenAIRouter(configPath string) (*OpenAIRouter, error) {
127127
}
128128

129129
// Create utility components
130-
piiChecker := pii.NewPolicyChecker(cfg.ModelConfig)
130+
piiChecker := pii.NewPolicyChecker(cfg, cfg.ModelConfig)
131131
ttftCalculator := ttft.NewCalculator(cfg.GPUConfig)
132132
modelTTFT := ttftCalculator.InitializeModelTTFT(cfg)
133133
classifier := classification.NewClassifier(cfg, categoryMapping, piiMapping, jailbreakMapping, modelTTFT)

src/semantic-router/pkg/extproc/security_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ var _ = Describe("Security Checks", func() {
5151
PIITypes: []string{"NO_PII"},
5252
},
5353
}
54-
router.PIIChecker = pii.NewPolicyChecker(cfg.ModelConfig)
54+
router.PIIChecker = pii.NewPolicyChecker(cfg, cfg.ModelConfig)
5555
router.Classifier = classification.NewClassifier(cfg, router.Classifier.CategoryMapping, router.Classifier.PIIMapping, nil, router.Classifier.ModelTTFT)
5656
})
5757

@@ -463,7 +463,7 @@ var _ = Describe("Security Checks", func() {
463463
PIITypes: []string{"NO_PII"},
464464
},
465465
}
466-
router.PIIChecker = pii.NewPolicyChecker(cfg.ModelConfig)
466+
router.PIIChecker = pii.NewPolicyChecker(cfg, cfg.ModelConfig)
467467

468468
response, err := router.HandleRequestBody(bodyRequest, ctx)
469469
Expect(err).NotTo(HaveOccurred())

src/semantic-router/pkg/extproc/test_utils_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ func CreateTestRouter(cfg *config.RouterConfig) (*extproc.OpenAIRouter, error) {
227227
classifier := classification.NewClassifier(cfg, categoryMapping, piiMapping, nil, modelTTFT)
228228

229229
// Create PII checker
230-
piiChecker := pii.NewPolicyChecker(cfg.ModelConfig)
230+
piiChecker := pii.NewPolicyChecker(cfg, cfg.ModelConfig)
231231

232232
// Create router manually with proper initialization
233233
router := &extproc.OpenAIRouter{

src/semantic-router/pkg/utils/pii/policy.go

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,30 @@ import (
88

99
// PolicyChecker handles PII policy validation
1010
type PolicyChecker struct {
11+
Config *config.RouterConfig
1112
ModelConfigs map[string]config.ModelParams
1213
}
1314

15+
// IsJailbreakEnabled checks if jailbreak detection is enabled and properly configured
16+
func (c *PolicyChecker) IsPIIEnabled() bool {
17+
return c.Config.PromptGuard.Enabled
18+
}
19+
1420
// NewPolicyChecker creates a new PII policy checker
15-
func NewPolicyChecker(modelConfigs map[string]config.ModelParams) *PolicyChecker {
21+
func NewPolicyChecker(cfg *config.RouterConfig, modelConfigs map[string]config.ModelParams) *PolicyChecker {
1622
return &PolicyChecker{
23+
Config: cfg,
1724
ModelConfigs: modelConfigs,
1825
}
1926
}
2027

2128
// CheckPolicy checks if the detected PII types are allowed for the given model
2229
func (pc *PolicyChecker) CheckPolicy(model string, detectedPII []string) (bool, []string, error) {
30+
if !pc.IsPIIEnabled() {
31+
log.Printf("PII detection is disabled, allowing request")
32+
return true, nil, nil
33+
}
34+
2335
modelConfig, exists := pc.ModelConfigs[model]
2436
if !exists {
2537
// If no specific config, allow by default

0 commit comments

Comments
 (0)