review feedback

Signed-off-by: Huamin Chen <[email protected]>

Author: rootfs

src/semantic-router/pkg/cache/hybrid_cache.go

@@ -580,9 +580,6 @@ func (h *HybridCache) FindSimilar(model string, query string) ([]byte, bool, err
 	metrics.RecordCacheOperation("hybrid", "find_similar", "miss", time.Since(start).Seconds())
 	metrics.RecordCacheMiss()
 
-	// Suppress context error to avoid noise
-	_ = ctx
-
 	return nil, false, nil
 }
 

src/semantic-router/pkg/cache/milvus_cache.go

@@ -205,10 +205,14 @@ func loadMilvusConfig(configPath string) (*MilvusConfig, error) {
 	fmt.Printf("[DEBUG]   Development.AutoCreateCollection: %v\n", config.Development.AutoCreateCollection)
 	fmt.Printf("[DEBUG]   Development.DropCollectionOnStartup: %v\n", config.Development.DropCollectionOnStartup)
 
-	// WORKAROUND: Force development settings for benchmarks
+	// WORKAROUND: Force development settings for benchmarks/tests only
 	// There seems to be a YAML parsing issue with sigs.k8s.io/yaml
-	if !config.Development.AutoCreateCollection && !config.Development.DropCollectionOnStartup {
-		fmt.Printf("[WARN] Development settings parsed as false, forcing to true for benchmarks\n")
+	// Only apply this workaround if SR_BENCHMARK_MODE or SR_TEST_MODE is set
+	benchmarkMode := os.Getenv("SR_BENCHMARK_MODE")
+	testMode := os.Getenv("SR_TEST_MODE")
+	if (benchmarkMode == "1" || benchmarkMode == "true" || testMode == "1" || testMode == "true") &&
+		!config.Development.AutoCreateCollection && !config.Development.DropCollectionOnStartup {
+		fmt.Printf("[WARN] Development settings parsed as false, forcing to true for benchmarks/tests\n")
 		config.Development.AutoCreateCollection = true
 		config.Development.DropCollectionOnStartup = true
 	}

src/semantic-router/pkg/cache/simd_benchmark_test.go

@@ -1,6 +1,7 @@
 package cache
 
 import (
+	"fmt"
 	"math/rand"
 	"testing"
 )
@@ -19,7 +20,7 @@ func BenchmarkDotProduct(b *testing.B) {
 			vec_b[i] = rand.Float32()
 		}
 
-		b.Run("SIMD/"+string(rune(size)), func(b *testing.B) {
+		b.Run(fmt.Sprintf("SIMD/%d", size), func(b *testing.B) {
 			b.ReportAllocs()
 			var sum float32
 			for i := 0; i < b.N; i++ {
@@ -28,7 +29,7 @@ func BenchmarkDotProduct(b *testing.B) {
 			_ = sum
 		})
 
-		b.Run("Scalar/"+string(rune(size)), func(b *testing.B) {
+		b.Run(fmt.Sprintf("Scalar/%d", size), func(b *testing.B) {
 			b.ReportAllocs()
 			var sum float32
 			for i := 0; i < b.N; i++ {