Skip to content

Commit d0404fd

Browse files
authored
api: remove unused health-check path in configuration (#201)
Signed-off-by: bitliu <[email protected]>
1 parent 7a0221b commit d0404fd

File tree

5 files changed

+10
-21
lines changed

5 files changed

+10
-21
lines changed

config/config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ vllm_endpoints:
3434
models:
3535
- "openai/gpt-oss-20b"
3636
weight: 1
37-
health_check_path: "/health"
3837

3938
model_config:
4039
"openai/gpt-oss-20b":

deploy/kubernetes/config.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,12 @@ vllm_endpoints:
3030
- "phi4"
3131
- "gemma3:27b"
3232
weight: 1 # Load balancing weight
33-
health_check_path: "/health" # Optional health check endpoint
3433
- name: "endpoint2"
3534
address: "127.0.0.1"
3635
port: 11434
3736
models:
3837
- "mistral-small3.1"
3938
weight: 1
40-
health_check_path: "/health"
4139
- name: "endpoint3"
4240
address: "127.0.0.1"
4341
port: 11434

src/semantic-router/pkg/config/config.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,6 @@ type VLLMEndpoint struct {
184184

185185
// Load balancing weight for this endpoint
186186
Weight int `yaml:"weight,omitempty"`
187-
188-
// Health check path for this endpoint
189-
HealthCheckPath string `yaml:"health_check_path,omitempty"`
190187
}
191188

192189
// ModelPricing represents configuration for model-specific parameters

src/semantic-router/pkg/config/config_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ vllm_endpoints:
9696
- "model-a"
9797
- "model-b"
9898
weight: 1
99-
health_check_path: "/health"
10099
- name: "endpoint2"
101100
address: "127.0.0.1"
102101
port: 8000
@@ -180,7 +179,6 @@ tools:
180179
Expect(cfg.VLLMEndpoints[0].Port).To(Equal(8000))
181180
Expect(cfg.VLLMEndpoints[0].Models).To(ContainElements("model-a", "model-b"))
182181
Expect(cfg.VLLMEndpoints[0].Weight).To(Equal(1))
183-
Expect(cfg.VLLMEndpoints[0].HealthCheckPath).To(Equal("/health"))
184182

185183
Expect(cfg.VLLMEndpoints[1].Name).To(Equal("endpoint2"))
186184
Expect(cfg.VLLMEndpoints[1].Address).To(Equal("127.0.0.1"))
@@ -794,7 +792,6 @@ vllm_endpoints:
794792
- "model-a"
795793
- "model-b"
796794
weight: 1
797-
health_check_path: "/health"
798795
- name: "endpoint2"
799796
address: "127.0.0.1"
800797
port: 8000

src/semantic-router/pkg/extproc/test_utils_test.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -172,20 +172,18 @@ func CreateTestConfig() *config.RouterConfig {
172172
},
173173
VLLMEndpoints: []config.VLLMEndpoint{
174174
{
175-
Name: "test-endpoint1",
176-
Address: "127.0.0.1",
177-
Port: 8000,
178-
Models: []string{"model-a", "model-b"},
179-
Weight: 1,
180-
HealthCheckPath: "/health",
175+
Name: "test-endpoint1",
176+
Address: "127.0.0.1",
177+
Port: 8000,
178+
Models: []string{"model-a", "model-b"},
179+
Weight: 1,
181180
},
182181
{
183-
Name: "test-endpoint2",
184-
Address: "127.0.0.1",
185-
Port: 8001,
186-
Models: []string{"model-b"},
187-
Weight: 2,
188-
HealthCheckPath: "/health",
182+
Name: "test-endpoint2",
183+
Address: "127.0.0.1",
184+
Port: 8001,
185+
Models: []string{"model-b"},
186+
Weight: 2,
189187
},
190188
},
191189
}

0 commit comments

Comments
 (0)