fix(classifier): resolve makeReasoningDecisionForCategory after PR #681 merge

After PR #681 merge, Categories no longer have ModelScores field.
The reasoning config moved to Decisions.ModelRefs, but there's no
direct mapping from category names to decision names.

Set useReasoning=false as safe default until proper category-to-decision
mapping is implemented.

Related: PR #648, PR #681
Signed-off-by: Yossi Ovadia <[email protected]>

Author: yossiovadia

src/semantic-router/pkg/classification/classifier.go

@@ -732,18 +732,14 @@ func (c *Classifier) classifyWithUnifiedClassifier(text string) (string, float64
 
 // makeReasoningDecisionForCategory creates reasoning decision based on category config
 func (c *Classifier) makeReasoningDecisionForCategory(category string, confidence float64) entropy.ReasoningDecision {
-	normalizedCategory := strings.ToLower(strings.TrimSpace(category))
+	// Note: In the new config architecture, reasoning configuration has moved from
+	// categories to decisions. However, the unified LoRA classifier returns category names
+	// (e.g., "business") while decisions have different names (e.g., "business_decision").
+	// For now, default to useReasoning=false since there's no direct mapping from
+	// category name to decision. This maintains backward compatibility and allows
+	// the system to function without reasoning until proper decision mapping is implemented.
 	useReasoning := false
 
-	for _, cat := range c.Config.Categories {
-		if strings.ToLower(cat.Name) == normalizedCategory {
-			if len(cat.ModelScores) > 0 && cat.ModelScores[0].UseReasoning != nil {
-				useReasoning = *cat.ModelScores[0].UseReasoning
-			}
-			break
-		}
-	}
-
 	return entropy.ReasoningDecision{
 		UseReasoning:     useReasoning,
 		Confidence:       confidence,