Skip to content

Commit e9a2d96

Browse files
committed
docs(milvus): improve troubleshooting section and monitoring script
Signed-off-by: samzong <[email protected]>
1 parent 6e40b71 commit e9a2d96

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

tools/milvus/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,13 @@ MILVUS_MODE=standalone RECREATE_CLUSTER=false CLEANUP=false ./tools/milvus/test-
4343
## Troubleshooting
4444

4545
**ServiceMonitor CRD Not Found:**
46+
4647
```bash
4748
# Add: --set metrics.serviceMonitor.enabled=false
4849
```
4950

5051
**Both Pulsar versions running:**
52+
5153
```bash
5254
# Add: --set pulsar.enabled=false --set pulsarv3.enabled=true
5355
```

tools/milvus/test-milvus-deployment.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,11 @@ section_monitoring() {
257257
if kubectl get crd servicemonitors.monitoring.coreos.com &> /dev/null; then
258258
log_info "Prometheus Operator detected"
259259
log_info "ServiceMonitor is enabled by default in Helm values"
260-
kubectl get servicemonitor -n "$NAMESPACE" 2>/dev/null && log_success "ServiceMonitor found" || log_warning "ServiceMonitor not yet created"
260+
if kubectl get servicemonitor -n "$NAMESPACE" 2>/dev/null; then
261+
log_success "ServiceMonitor found"
262+
else
263+
log_warning "ServiceMonitor not yet created"
264+
fi
261265
else
262266
log_warning "Prometheus Operator not installed, ServiceMonitor will not be created"
263267
fi

0 commit comments

Comments
 (0)