Skip to content

Commit f72834e

Browse files
committed
Remove -run filter that doesn't work with Ginkgo tests
- Ginkgo tests don't use Go's standard -run flag for filtering - All tests are under TestE2ETestcases function, not separate Test functions - Removed -run "Keyword Routing" from test execution - Removed -run "Keyword Routing" from race detector - Tests now run successfully and achieve 87.1% coverage of keyword_classifier.go Signed-off-by: Senan Zedan <[email protected]>
1 parent b5fabfd commit f72834e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/unit-test-e2e-testcases.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
run: |
7474
cd e2e-tests/testcases
7575
echo "Running keyword routing tests..."
76-
go test -v -run "Keyword Routing" -coverprofile=coverage-keyword.out -covermode=atomic -coverpkg=github.com/vllm-project/semantic-router/src/semantic-router/pkg/classification
76+
go test -v -coverprofile=coverage-keyword.out -covermode=atomic -coverpkg=github.com/vllm-project/semantic-router/src/semantic-router/pkg/classification
7777
7878
- name: Generate coverage report
7979
if: always()
@@ -246,7 +246,7 @@ jobs:
246246
run: |
247247
cd e2e-tests/testcases
248248
echo "Running tests with race detector..."
249-
go test -race -v -run "Keyword Routing" || {
249+
go test -race -v || {
250250
echo "❌ Race conditions detected!"
251251
exit 1
252252
}

0 commit comments

Comments
 (0)