Skip to content

[Precommit newline] In the SR project, should all the files end on a new line? #443

@yuluo-yx

Description

@yuluo-yx

refer: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206

In the SR project, some files do not end on a new line.
Should we add a makefile tool to check and fix them? WDYT @rootfs @Xunzhuo @JaredforReal

such as: make new-lint-check
get:

./.gitignore
./tools/linter/go/.golangci.yml
./tools/observability/llm-router-dashboard.json
./tools/make/milvus.mk
./tools/make/openshift.mk
./config/tools_db.json
./deploy/openshift/template.yaml
./deploy/openshift/deployment.yaml
./deploy/openshift/kustomization.yaml
./deploy/openshift/config-openshift.yaml
./deploy/openshift/deploy-to-openshift.sh
./deploy/openshift/cleanup-openshift.sh
./deploy/openshift/envoy-openshift.yaml
./deploy/openshift/Dockerfile.llm-katan
./deploy/openshift/openwebui/deployment.yaml
./deploy/openshift/openwebui/kustomization.yaml
./deploy/openshift/openwebui/deploy-openwebui-on-openshift.sh
./deploy/openshift/openwebui/service.yaml
./deploy/openshift/openwebui/route.yaml
./deploy/openshift/openwebui/pvc.yaml
./deploy/openshift/openwebui/uninstall-openwebui.sh
./deploy/docker-compose/addons/llm-router-dashboard.json
./deploy/kubernetes/tools_db.json
./deploy/kubernetes/istio/tools_db.json
./website/src/components/ZoomableMermaid/styles.module.css
./e2e-tests/start-llm-katan.sh
./e2e-tests/llm-katan/pyproject.toml
./e2e-tests/llm-katan/.gitignore
./e2e-tests/llm-katan/demo-embed.html
./e2e-tests/llm-katan/terminal-demo.html
./dashboard/OWNER
./scripts/quickstart.sh
./src/OWNER
./src/training/training_lora/OWNER
./src/training/training_lora/prompt_guard_fine_tuning_lora/go.mod
./src/training/training_lora/prompt_guard_fine_tuning_lora/train_cpu_optimized.sh
./src/training/training_lora/pii_model_fine_tuning_lora/go.mod
./src/training/training_lora/pii_model_fine_tuning_lora/train_cpu_optimized.sh
./src/training/training_lora/classifier_model_fine_tuning_lora/go.mod
./src/training/training_lora/classifier_model_fine_tuning_lora/train_cpu_optimized.sh

run make new-line-fix, add newline

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions