feat: add helm support deploy support #532
Conversation
yuluo-yx
commented
Oct 24, 2025
yuluo-yx
commented
- Fixed Semantic Router Helm Chart Support #277
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Helm chart support for deploying Semantic Router on Kubernetes, providing an alternative to the existing Kustomize deployment method. The implementation includes production and development configurations, validation tooling, and extensive Make target automation.
Key Changes
- Added complete Helm chart structure with templates for all Kubernetes resources (Deployment, Service, ConfigMap, PVC, Ingress, HPA, etc.)
- Introduced environment-specific values files (dev, prod, example) with optimized configurations for different deployment scenarios
- Integrated Helm deployment automation through Make targets and validation scripts
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 22 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/make/helm.mk | Comprehensive Make targets for Helm operations including install, upgrade, testing, and port-forwarding |
| tools/make/linter.mk | Removed documentation linting targets (likely relocated or obsolete) |
| deploy/helm/semantic-router/Chart.yaml | Helm chart metadata and project information |
| deploy/helm/semantic-router/values.yaml | Default configuration values for the Helm deployment |
| deploy/helm/semantic-router/values-dev.yaml | Development environment optimized values |
| deploy/helm/semantic-router/values-prod.yaml | Production environment optimized values with HA setup |
| deploy/helm/semantic-router/values-example.yaml | Example configuration demonstrating customization options |
| deploy/helm/semantic-router/templates/*.yaml | Kubernetes resource templates for deployment infrastructure |
| deploy/helm/semantic-router/templates/_helpers.tpl | Helm template helper functions |
| deploy/helm/validate-chart.sh | Automated validation script for chart testing |
| deploy/helm/README.md | Comprehensive deployment guide with examples |
| deploy/helm/semantic-router/README.md | Detailed chart documentation |
| Makefile | Integration of helm.mk into main build system |
Comments suppressed due to low confidence (1)
deploy/helm/semantic-router/values.yaml:1
- Inconsistent model path format. Line 218 uses 'models/all-MiniLM-L12-v2' (with 'models/' prefix) while line 57 uses 'sentence-transformers/all-MiniLM-L12-v2' (repository format). These should be consistent - line 218 should match the repository format used for downloading.
# Default values for semantic-router.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
If all goes well, it should be possible to do this. I've been quite busy lately, but I'll test it locally this weekend and prepare for the merge. 👀 when I'm ready to merge, pls review the code if you have time. thx @nithin8702 |
|
@yuluo-yx Could you please confirm your PR works with nginx ingress or envoy ai gateway? Is there a way i can test your helm chart now? Also there is a chat going on in Slack. Please check |
you can use |
Signed-off-by: jishiwen.jsw <[email protected]>
yuluo-yx
changed the title
|
@yuluo-yx this is great! would you please add a CI test too, either in this PR or in a followup PR. Thanks |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
deploy/helm/semantic-router/values.yaml:1
- Setting
runAsNonRoot: falsein default values is a security concern. This allows the container to run as root user, which contradicts the best practice shown in production values. The default should betrueto enforce running as non-root unless explicitly overridden for specific use cases.
# Default values for semantic-router.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
4 participants
