Skip to content

Conversation

@yehudit1987
Copy link
Contributor

  • Fix incorrect relative path to models directory
  • Fix Rust double initialization bug in init_lora_unified_classifier
  • Add LoRA models to CI minimal downloads
  • Bump model cache version to force fresh download
  • Change tests to fail visibly instead of silently skipping

Tests TestAutoDiscoverModels_RealModels, TestAutoInitializeUnifiedClassifier,
and TestUnifiedClassifier_Integration now pass.

Fix Partially issue #573

@netlify
Copy link

netlify bot commented Nov 11, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 608c921
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6914dbc44cafb300087e4877
😎 Deploy Preview https://deploy-preview-632--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • .github/workflows/test-and-build.yml

📁 candle-binding

Owners: @rootfs
Files changed:

  • candle-binding/src/ffi/init.rs

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/classification/classifier_test.go

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/make/models.mk

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@yehudit1987 yehudit1987 force-pushed the fix_skipped_tests_clean branch from be4e510 to ace578b Compare November 11, 2025 08:29
@yehudit1987 yehudit1987 marked this pull request as ready for review November 11, 2025 09:13
@rootfs
Copy link
Collaborator

rootfs commented Nov 11, 2025

@yuluo-yx PTAL, thanks

@yehudit1987 yehudit1987 force-pushed the fix_skipped_tests_clean branch 2 times, most recently from 661fa78 to 368f71b Compare November 12, 2025 09:00
Signed-off-by: Yehudit Kerido <[email protected]>
@yehudit1987 yehudit1987 force-pushed the fix_skipped_tests_clean branch from 368f71b to 608c921 Compare November 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants