-
Notifications
You must be signed in to change notification settings - Fork 302
[Feat] add model-downloader image and CI workflow for ghcr publishing #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] add model-downloader image and CI workflow for ghcr publishing #738
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
I think it's can be split to 2 PRs. Currently forcing build image and pushlish image. Then upgrade helm chart. |
03c3bc2 to
9353ea5
Compare
Signed-off-by: samzong <[email protected]>
9353ea5 to
f2ae785
Compare
|
@samzong thanks! once you've have the container image, we'll add to the ghcr publish pipeline so you can use the published image in helm. |
|
@rootfs Thanks. The image is actually built in this PR's workflow. Once this PR is merged, the model-downloader image will be available on ghcr. After that I can send the follow-up PR to update the Helm chart. |

FILL IN THE PR DESCRIPTION HERE
FIX #678 (link existing issues this PR will resolve)
Support a dedicated multi-arch model-downloader image (Dockerfile + workflow wiring)
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews