Skip to content

fix(test): correct relative path for PII LoRA model in auto-detection test #787

@yossiovadia

Description

@yossiovadia

Issue Description

The PII auto-detection test in src/semantic-router/pkg/classification/lora_auto_detection_test.go uses an incorrect relative path for the test model, causing the test to silently skip instead of running.

Current Problem

Line 92:

modelPath := "models/lora_pii_detector_bert-base-uncased_model"

Should be:

modelPath := "../../../../models/lora_pii_detector_bert-base-uncased_model"

Impact

  • The test currently skips when the path isn't found (line 96)
  • This means the PII auto-detection test has been silently skipping on every run
  • The intent classification test (line 14) uses the correct relative path as reference

Referenced Discussion

From PR #726 review discussion:
#726 (comment)

Acceptance Criteria

  • Fix the relative path in TestPIIAlreadyHasAutoDetection to match the pattern used in TestIntentClassificationAutoDetection
  • Verify the test actually runs (doesn't skip)
  • Confirm the test passes with the correct path

Related

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions