Skip to content

Conversation

@yuluo-yx
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 58b7765
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68c98eeae504c200081b703c
😎 Deploy Preview https://deploy-preview-149--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • tools/make/OWNER
  • tools/make/build-run-test.mk
  • tools/make/common.mk
  • tools/make/docs.mk
  • tools/make/envoy.mk
  • tools/make/envs.mk
  • tools/make/golang.mk
  • tools/make/linter.mk
  • tools/make/milvus.mk
  • tools/make/models.mk
  • tools/make/rust.mk
  • Makefile

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@yuluo-yx yuluo-yx force-pushed the 0917-yuluo/refactor-makefile branch from 6d0d62d to bcdc038 Compare September 16, 2025 16:17
@yuluo-yx yuluo-yx force-pushed the 0917-yuluo/refactor-makefile branch from bcdc038 to 58b7765 Compare September 16, 2025 16:23
@rootfs
Copy link
Collaborator

rootfs commented Sep 16, 2025

merging the PR so we can run the image build test on CI

@rootfs rootfs merged commit b140918 into vllm-project:main Sep 16, 2025
9 checks passed
@rootfs
Copy link
Collaborator

rootfs commented Sep 16, 2025

Dockerfile needs to update too

#22 [rust-builder 6/7] COPY candle-binding/src/ candle-binding/src/
#22 DONE 0.0s

#23 [rust-builder 7/7] RUN make rust
#23 0.136 make[1]: tools/make/common.mk: No such file or directory
#23 0.136 make[1]: tools/make/envs.mk: No such file or directory
#23 0.136 make[1]: tools/make/envoy.mk: No such file or directory
#23 0.136 make[1]: tools/make/golang.mk: No such file or directory
#23 0.136 make[1]: tools/make/rust.mk: No such file or directory
#23 0.136 make[1]: tools/make/build-run-test.mk: No such file or directory
#23 0.136 make[1]: tools/make/docs.mk: No such file or directory
#23 0.136 make[1]: tools/make/linter.mk: No such file or directory
#23 0.136 make[1]: Entering directory '/app'
#23 0.136 make[1]: tools/make/milvus.mk: No such file or directory
#23 0.136 make[1]: tools/make/models.mk: No such file or directory
#23 0.137 make[1]: *** No rule to make target 'tools/make/models.mk'.  Stop.
#23 0.137 make[1]: Leaving directory '/app'
#23 0.137 make: *** [Makefile:5: _run] Error 2
#23 ERROR: process "/bin/sh -c make rust" did not complete successfully: exit code: 2
------
 > [rust-builder 7/7] RUN make rust:
0.136 make[1]: tools/make/rust.mk: No such file or directory
0.136 make[1]: tools/make/build-run-test.mk: No such file or directory
0.136 make[1]: tools/make/docs.mk: No such file or directory
0.136 make[1]: tools/make/linter.mk: No such file or directory
0.136 make[1]: Entering directory '/app'
0.136 make[1]: tools/make/milvus.mk: No such file or directory
0.136 make[1]: tools/make/models.mk: No such file or directory
0.137 make[1]: *** No rule to make target 'tools/make/models.mk'.  Stop.
0.137 make[1]: Leaving directory '/app'
0.137 make: *** [Makefile:5: _run] Error 2
------

 2 warnings found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 2)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 22)
Dockerfile.extproc:19
--------------------
  17 |     
  18 |     # Use Makefile to build the Rust library
  19 | >>> RUN make rust
  20 |     
  21 |     # Build the Go application
--------------------

@rootfs
Copy link
Collaborator

rootfs commented Sep 16, 2025

@yuluo-yx can you follow up with this and update the dockerfile? thanks

@yuluo-yx yuluo-yx deleted the 0917-yuluo/refactor-makefile branch September 16, 2025 17:27
@yuluo-yx
Copy link
Contributor Author

@yuluo-yx can you follow up with this and update the dockerfile? thanks

It's a bit late today, I will create a pr update tomorrow night 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infra: refactor makefile

3 participants