Skip to content

Conversation

@samzong
Copy link
Contributor

@samzong samzong commented Sep 17, 2025

What type of PR is this?

docs: add error metrics and example queries for llm_request_errors_total

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #133

Release Notes: No

@samzong samzong requested a review from Xunzhuo as a code owner September 17, 2025 06:20
@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit e353f9b
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68cd81d8a64f550008066336
😎 Deploy Preview https://deploy-preview-156--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/api/router.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@samzong samzong force-pushed the docs/upgrade-error-metrics branch from b1a8280 to f929a21 Compare September 17, 2025 07:14
@rootfs
Copy link
Collaborator

rootfs commented Sep 17, 2025

@tao12345666333 Thanks for the review, is it ok to merge?

@tao12345666333
Copy link
Contributor

@rootfs please wait. We haven’t reached an agreement yet. I will write a detailed explanation for this tomorrow.

#156 (comment)

Co-authored-by: Jintao Zhang <[email protected]>
Signed-off-by: samzong <[email protected]>
@samzong samzong force-pushed the docs/upgrade-error-metrics branch from 66d634a to 19a6ba7 Compare September 19, 2025 15:20
@rootfs
Copy link
Collaborator

rootfs commented Sep 19, 2025

@samzong thanks!
@tao12345666333 wdyt?

Copy link
Contributor

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tao12345666333
Copy link
Contributor

We can merge this, thank you

@rootfs rootfs merged commit 5d90816 into vllm-project:main Sep 19, 2025
9 checks passed
yossiovadia pushed a commit to yossiovadia/semantic-router that referenced this pull request Oct 8, 2025
…t_errors_total (vllm-project#156)

* docs(router): add error metrics and example queries for llm_request_errors_total

Signed-off-by: samzong <[email protected]>

* Update website/docs/api/router.md

Co-authored-by: Jintao Zhang <[email protected]>
Signed-off-by: samzong <[email protected]>

---------

Signed-off-by: samzong <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
Co-authored-by: Huamin Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Add description for RequestErrorsTotal

4 participants