metrics: Add request-level token histograms #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao12345666333
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
I don’t think the CI error is related to the changes in this PR. |
yuluo-yx
reviewed
Sep 17, 2025
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
tao12345666333
force-pushed
the
o11y-metrics-token-histograms-category
branch
from
ad70826 to
15374f0
Compare
yuluo-yx
approved these changes
Sep 18, 2025
rootfs
approved these changes
Sep 18, 2025
yossiovadia
pushed a commit
to yossiovadia/semantic-router
that referenced
this pull request
Sep 22, 2025
* metrics: Add request-level token histograms Signed-off-by: Jintao Zhang <[email protected]> * add unknown const Signed-off-by: Jintao Zhang <[email protected]> --------- Signed-off-by: Jintao Zhang <[email protected]>
yossiovadia
pushed a commit
to yossiovadia/semantic-router
that referenced
this pull request
Oct 8, 2025
* metrics: Add request-level token histograms Signed-off-by: Jintao Zhang <[email protected]> * add unknown const Signed-off-by: Jintao Zhang <[email protected]> --------- Signed-off-by: Jintao Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
metrics: Add request-level token histograms
What this PR does / why we need it:
Add request-level token histograms:
• llm_prompt_tokens_per_request (HistogramVec; labels: model)
• llm_completion_tokens_per_request (HistogramVec; labels: model)
Introduce a Counter for category mix:
• llm_category_classifications_count (CounterVec; labels: category)
Remove existing Gauge
llm_category_classifications_totalWhich issue(s) this PR fixes:
Fixes #123
Release Notes: Yes/No