Skip to content

Conversation

@ZeroZ-lab
Copy link
Contributor

@ZeroZ-lab ZeroZ-lab commented Sep 2, 2025

What type of PR is this?

Standardizes logging practices across the codebase to improve maintainability .

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 candle-binding

Owners: @rootfs
Files changed:

  • candle-binding/semantic-router.go

This comment was automatically generated based on the OWNER files in the repository.

@netlify
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit a33dbe4
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68b69c2cdaef390008726d97
😎 Deploy Preview https://deploy-preview-19--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 2, 2025

@ZeroZ-lab Please sign your commit

…m fmt.Println to log.Printf to unify the logging method.

Signed-off-by: GuanMu <[email protected]>
@ZeroZ-lab
Copy link
Contributor Author

sign your commit

OK, I have signed my commit.

@Xunzhuo Xunzhuo changed the title fix(logging): Change the initialization model's print information from fmt.Println to log.Printf to unify the logging method. chore(logging): unify the logging method Sep 2, 2025
@Xunzhuo Xunzhuo merged commit 8a8fcc5 into vllm-project:main Sep 2, 2025
9 checks passed
@ZeroZ-lab ZeroZ-lab deleted the fix-log branch September 2, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants