e2e test: 02-router-classification: verify router classification #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssification-test.py - Fix import path: change from 'tests.test_base' to 'test_base' - Add missing 'import unittest' statement - Update DEFAULT_MODEL from 'qwen2.5:32b' to 'Model-A' to match e2e config - Increase timeout from 10s to 60s to accommodate LLM Katan response times - Use 'model: auto' to trigger category-based classification routing - Add 4 comprehensive test cases: math, computer science, business, history - Add expected_model field to verify correct routing - Add assertions to verify actual model matches expected model - Enhance test output to show expected vs actual routing - Fix metrics test to check for actual exposed metrics (entropy classification, cache) - Update README to mark 01 and 02 tests as completed with descriptions All 3 tests now pass successfully with verified classification routing: - Category Classification: Math→Model-B, CS→Model-B, Business→Model-A, History→Model-A ✅ - Classification Consistency: Same query routes to same model ✅ - Router Metrics: Entropy classification, cache hits/misses tracked ✅ Signed-off-by: Yossi Ovadia <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
previously approved these changes
Oct 1, 2025
Remove trailing whitespace from lines 239, 297, and 298 to pass pre-commit checks. Signed-off-by: Yossi Ovadia <[email protected]>
Add trailing comma after last argument in assertGreater call to comply with black formatting standards. Signed-off-by: Yossi Ovadia <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…m-project#302) * fix: enable and verify router classification testing in 02-router-classification-test.py - Fix import path: change from 'tests.test_base' to 'test_base' - Add missing 'import unittest' statement - Update DEFAULT_MODEL from 'qwen2.5:32b' to 'Model-A' to match e2e config - Increase timeout from 10s to 60s to accommodate LLM Katan response times - Use 'model: auto' to trigger category-based classification routing - Add 4 comprehensive test cases: math, computer science, business, history - Add expected_model field to verify correct routing - Add assertions to verify actual model matches expected model - Enhance test output to show expected vs actual routing - Fix metrics test to check for actual exposed metrics (entropy classification, cache) - Update README to mark 01 and 02 tests as completed with descriptions All 3 tests now pass successfully with verified classification routing: - Category Classification: Math→Model-B, CS→Model-B, Business→Model-A, History→Model-A ✅ - Classification Consistency: Same query routes to same model ✅ - Router Metrics: Entropy classification, cache hits/misses tracked ✅ Signed-off-by: Yossi Ovadia <[email protected]> * fix: remove trailing whitespace in 02-router-classification-test.py Remove trailing whitespace from lines 239, 297, and 298 to pass pre-commit checks. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatter to 02-router-classification-test.py Add trailing comma after last argument in assertGreater call to comply with black formatting standards. Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
…m-project#302) * fix: enable and verify router classification testing in 02-router-classification-test.py - Fix import path: change from 'tests.test_base' to 'test_base' - Add missing 'import unittest' statement - Update DEFAULT_MODEL from 'qwen2.5:32b' to 'Model-A' to match e2e config - Increase timeout from 10s to 60s to accommodate LLM Katan response times - Use 'model: auto' to trigger category-based classification routing - Add 4 comprehensive test cases: math, computer science, business, history - Add expected_model field to verify correct routing - Add assertions to verify actual model matches expected model - Enhance test output to show expected vs actual routing - Fix metrics test to check for actual exposed metrics (entropy classification, cache) - Update README to mark 01 and 02 tests as completed with descriptions All 3 tests now pass successfully with verified classification routing: - Category Classification: Math→Model-B, CS→Model-B, Business→Model-A, History→Model-A ✅ - Classification Consistency: Same query routes to same model ✅ - Router Metrics: Entropy classification, cache hits/misses tracked ✅ Signed-off-by: Yossi Ovadia <[email protected]> * fix: remove trailing whitespace in 02-router-classification-test.py Remove trailing whitespace from lines 239, 297, and 298 to pass pre-commit checks. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatter to 02-router-classification-test.py Add trailing comma after last argument in assertGreater call to comply with black formatting standards. Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All 3 tests now pass successfully with verified classification routing:
Release Notes: No