refactor(config): remove models field from vLLM endpoints #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the redundant models field from VLLMEndpoint configuration. Model-to-endpoint mapping is now solely determined by the preferred_endpoints field in model_config, eliminating the need for bidirectional association. Changes: - Remove Models field from VLLMEndpoint struct - Update GetEndpointsForModel to use only preferred_endpoints - Update GetAllModels to retrieve models from model_config keys - Update all configuration files to remove models field - Update all tests to reflect the new configuration structure - Update TypeScript interface in dashboard frontend This simplifies the configuration and removes potential inconsistencies between models and preferred_endpoints. Signed-off-by: bitliu <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
rootfs
approved these changes
Oct 13, 2025
|
cc @yossiovadia for e2e tests |
joyful-ii-V-I
pushed a commit
to joyful-ii-V-I/semantic-router
that referenced
this pull request
Oct 13, 2025
…ct#413) * refactor(config): remove models field from vLLM endpoints Remove the redundant models field from VLLMEndpoint configuration. Model-to-endpoint mapping is now solely determined by the preferred_endpoints field in model_config, eliminating the need for bidirectional association. Changes: - Remove Models field from VLLMEndpoint struct - Update GetEndpointsForModel to use only preferred_endpoints - Update GetAllModels to retrieve models from model_config keys - Update all configuration files to remove models field - Update all tests to reflect the new configuration structure - Update TypeScript interface in dashboard frontend This simplifies the configuration and removes potential inconsistencies between models and preferred_endpoints. Signed-off-by: bitliu <[email protected]> * more Signed-off-by: bitliu <[email protected]> * more Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the redundant models field from VLLMEndpoint configuration. Model-to-endpoint mapping is now solely determined by the preferred_endpoints field in model_config, eliminating the need for bidirectional association.
Changes:
This simplifies the configuration and removes potential inconsistencies between models and preferred_endpoints.