-
Notifications
You must be signed in to change notification settings - Fork 275
feat: code polish on classifier #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you give it a simple conclusion of what you optimized for classifier?
sure,
|
|
ok thanks! can you separate the ut to another pr which is easier to go ahead, and remember to sign your commit |
|
and add ut around your code polish in this PR to make sure things go in expectations. |
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: bitliu <[email protected]> Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: bitliu <[email protected]> Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: bitliu <[email protected]> Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: bitliu <[email protected]> Signed-off-by: yuluo-yx <[email protected]>
Update comment to improve clarity and correctness. Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
d1d902e to
d612c34
Compare
Signed-off-by: bitliu <[email protected]>
hi I split ttft ut to #68, pls |
Uh oh!
There was an error while loading. Please reload this page.