From 2e7ea2bc7048b88fe4a2511e81cc2a56802ae5c3 Mon Sep 17 00:00:00 2001 From: Senan Zedan Date: Wed, 26 Nov 2025 09:28:35 +0200 Subject: [PATCH 1/2] fix the ci test for quickstart.sh script, In case we had failure to download embeddinggemma-300m, fall back to minimal models Signed-off-by: Senan Zedan --- scripts/quickstart.sh | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/scripts/quickstart.sh b/scripts/quickstart.sh index a1bc14126..c071a2215 100755 --- a/scripts/quickstart.sh +++ b/scripts/quickstart.sh @@ -158,16 +158,37 @@ download_models() { info_msg "📥 Downloading AI models..." echo - # Use minimal model set for faster setup - export CI_MINIMAL_MODELS=false + # Try full model set first (includes embeddinggemma-300m which may require auth) + # If that fails (e.g., 401 on gated models), fall back to minimal set + if [ "${CI_MINIMAL_MODELS:-}" = "true" ]; then + info_msg "CI_MINIMAL_MODELS=true detected, using minimal model set" + export CI_MINIMAL_MODELS=true + else + info_msg "Attempting to download full model set (includes embeddinggemma-300m)..." + export CI_MINIMAL_MODELS=false + fi # Download models and save output to log (visible in real-time) if make download-models 2>&1 | tee /tmp/download-models-output.log; then success_msg "✅ Models downloaded successfully!" else - error_msg "❌ Failed to download models!" - info_msg "📋 Check logs: cat /tmp/download-models-output.log" - exit 1 + # Check if failure was due to gated model (embeddinggemma-300m) + if grep -q "embeddinggemma.*401\|embeddinggemma.*Unauthorized\|embeddinggemma.*GatedRepoError" /tmp/download-models-output.log 2>/dev/null; then + info_msg "⚠️ Full model download failed (gated model requires auth)" + info_msg "📋 Falling back to minimal model set..." + export CI_MINIMAL_MODELS=true + if make download-models 2>&1 | tee /tmp/download-models-output.log; then + success_msg "✅ Minimal models downloaded successfully!" + else + error_msg "❌ Failed to download even minimal models!" + info_msg "📋 Check logs: cat /tmp/download-models-output.log" + exit 1 + fi + else + error_msg "❌ Failed to download models!" + info_msg "📋 Check logs: cat /tmp/download-models-output.log" + exit 1 + fi fi echo } From d89a52121414d25a4335acb637966c186c91a45f Mon Sep 17 00:00:00 2001 From: Senan Zedan Date: Wed, 26 Nov 2025 11:47:42 +0200 Subject: [PATCH 2/2] fix(ci): re-enable docker-compose integration test triggers Restore pull_request and push triggers for the Integration Test [Docker Compose] workflow that were removed in commit 0e3a669. The workflow now runs on: - Pull requests to main (excluding website/** and **.md) - Pushes to main (excluding website/** and **.md) - Manual workflow_dispatch triggers This ensures the docker-compose integration test runs automatically for all PRs, catching issues before merge. The test now passes with the fallback logic in quickstart.sh that handles gated model failures. Signed-off-by: Senan Zedan --- .github/workflows/integration-test-docker.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/integration-test-docker.yml b/.github/workflows/integration-test-docker.yml index 3bff94a3f..94447d90a 100644 --- a/.github/workflows/integration-test-docker.yml +++ b/.github/workflows/integration-test-docker.yml @@ -1,6 +1,18 @@ name: Integration Test [Docker Compose] on: + pull_request: + branches: + - main + paths-ignore: + - 'website/**' + - '**/*.md' + push: + branches: + - main + paths-ignore: + - 'website/**' + - '**/*.md' workflow_dispatch: # Allow manual triggering jobs: