fix(test): correct relative path for PII LoRA model in auto-detection test #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test The PII auto-detection test was using an incorrect relative path "models/lora_pii_detector_bert-base-uncased_model" which would fail when running from the test directory location. Updated to use the correct relative path "../../../../models/lora_pii_detector_bert-base-uncased_model" to match the pattern used in the intent classification test. This ensures the test can locate the model files correctly and doesn't skip when the LoRA PII model is available. Fixes vllm-project#787 Signed-off-by: Yossi Ovadia <[email protected]>
yossiovadia
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the incorrect relative path in the PII auto-detection test that prevented it from locating the LoRA model files.
Changes
TestPIIAlreadyHasAutoDetectionto use correct relative pathmodels/lora_pii_detector_bert-base-uncased_modelto../../../../models/lora_pii_detector_bert-base-uncased_modelTest Plan
Related Issues
Closes #787