Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Sep 28, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Yikun Yikun added ready read for review ready-for-test start test by label for PR labels Sep 28, 2025
@Yikun
Copy link
Collaborator Author

Yikun commented Sep 28, 2025

I suspect it has something to do with running the test case, but I can't reproduce the test case at my local env

all tests passed
and eagle failed but no OOM
FAILED tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py::test_eagle_correctness[eagle] - AssertionError: assert 6 > 6
FAILED tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py::test_eagle_correctness[eagle3] - AssertionError: assert 6 > 6

Let's see is it OK in this PR (only run all spec_decode test)

@Yikun
Copy link
Collaborator Author

Yikun commented Sep 28, 2025

Failed as expected: https://github.com/vllm-project/vllm-ascend/actions/runs/18081163582/job/51444630922?pr=3250

Let's only run eagle then

@Yikun
Copy link
Collaborator Author

Yikun commented Sep 29, 2025

pytest -sv tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py

only run eagle, PASSED: https://github.com/vllm-project/vllm-ascend/actions/runs/18081477286/job/51445359952?pr=3250

@Yikun
Copy link
Collaborator Author

Yikun commented Sep 29, 2025

npu-smi info
pytest -sv tests/e2e/singlecard/spec_decode_v1/test_v1_mtp_torchair_correctness.py
npu-smi info
pytest -sv tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py

Passed: https://github.com/vllm-project/vllm-ascend/actions/runs/18081893242/job/51446420430?pr=3250

Signed-off-by: Yikun Jiang <[email protected]>
@Yikun
Copy link
Collaborator Author

Yikun commented Sep 29, 2025

npu-smi info
pytest -sv tests/e2e/singlecard/spec_decode_v1/test_v1_mtp_correctness.py
npu-smi info
pytest -sv tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the ready read for review label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflicts ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant