Skip to content

Commit 2fc5d6e

Browse files
Fix LLMEngine.del dp_group cleanup condition (#29954)
Signed-off-by: Yongtao Huang <[email protected]>
1 parent afe9eb4 commit 2fc5d6e

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

vllm/v1/engine/llm_engine.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,6 @@ def apply_model(self, func: Callable[[nn.Module], _R]) -> list[_R]:
409409
return self.collective_rpc("apply_model", args=(func,))
410410

411411
def __del__(self):
412-
if (
413-
dp_group := getattr(self, "dp_group", None)
414-
and not self.external_launcher_dp
415-
):
412+
dp_group = getattr(self, "dp_group", None)
413+
if dp_group is not None and not self.external_launcher_dp:
416414
stateless_destroy_torch_distributed_process_group(dp_group)

0 commit comments

Comments
 (0)