Skip to content

Commit 39f66e5

Browse files
zhuohan123luccafong
authored andcommitted
minor fix
Signed-off-by: Zhuohan Li <[email protected]>
1 parent bf70583 commit 39f66e5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

vllm/v1/engine/llm_engine.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import vllm.envs as envs
1212
from vllm.config import ParallelConfig, VllmConfig
1313
from vllm.distributed import stateless_destroy_torch_distributed_process_group
14+
from vllm.distributed.parallel_state import get_dp_group
1415
from vllm.engine.arg_utils import EngineArgs
1516
from vllm.inputs import PromptType
1617
from vllm.logger import init_logger
@@ -125,11 +126,11 @@ def __init__(
125126
# for v0 compatibility
126127
self.model_executor = self.engine_core.engine_core.model_executor # type: ignore
127128

128-
self.external_launcher_dp = (parallel_config.data_parallel_size > 1 and
129-
executor_backend == "external_launcher")
130129
if self.external_launcher_dp:
131-
from vllm.distributed.parallel_state import get_dp_group
130+
# If we use DP in external launcher mode, we reuse the
131+
# existing DP group used for data communication.
132132
self.dp_group = get_dp_group().cpu_group
133+
133134
# Don't keep the dummy data in memory
134135
self.reset_mm_cache()
135136

0 commit comments

Comments
 (0)