Skip to content

Commit 808632d

Browse files
authored
[BugFix] Prevent the task of _force_log from being garbage collected (#4567)
1 parent 344a5d0 commit 808632d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

vllm/entrypoints/openai/api_server.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import re
55
from contextlib import asynccontextmanager
66
from http import HTTPStatus
7+
from typing import Any, Set
78

89
import fastapi
910
import uvicorn
@@ -33,6 +34,8 @@
3334
openai_serving_completion: OpenAIServingCompletion
3435
logger = init_logger(__name__)
3536

37+
_running_tasks: Set[asyncio.Task[Any]] = set()
38+
3639

3740
@asynccontextmanager
3841
async def lifespan(app: fastapi.FastAPI):
@@ -43,7 +46,9 @@ async def _force_log():
4346
await engine.do_log_stats()
4447

4548
if not engine_args.disable_log_stats:
46-
asyncio.create_task(_force_log())
49+
task = asyncio.create_task(_force_log())
50+
_running_tasks.add(task)
51+
task.add_done_callback(_running_tasks.remove)
4752

4853
yield
4954

0 commit comments

Comments
 (0)