Skip to content

Commit 87b4ac5

Browse files
authored
[CI][Bugfix] Fix bad tolerance for test_batch_base64_embedding (#16221)
Signed-off-by: mgoin <[email protected]>
1 parent cb84e45 commit 87b4ac5

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

tests/entrypoints/openai/test_embedding.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from vllm.entrypoints.openai.protocol import EmbeddingResponse
1212
from vllm.transformers_utils.tokenizer import get_tokenizer
1313

14+
from ...models.embedding.utils import check_embeddings_close
1415
from ...utils import RemoteOpenAIServer
1516

1617
MODEL_NAME = "intfloat/multilingual-e5-small"
@@ -190,30 +191,35 @@ async def test_batch_base64_embedding(client: openai.AsyncOpenAI,
190191
responses_float = await client.embeddings.create(input=input_texts,
191192
model=model_name,
192193
encoding_format="float")
194+
float_data = [d.embedding for d in responses_float.data]
193195

194196
responses_base64 = await client.embeddings.create(input=input_texts,
195197
model=model_name,
196198
encoding_format="base64")
197-
198-
decoded_responses_base64_data = []
199+
base64_data = []
199200
for data in responses_base64.data:
200-
decoded_responses_base64_data.append(
201+
base64_data.append(
201202
np.frombuffer(base64.b64decode(data.embedding),
202203
dtype="float32").tolist())
203204

204-
assert responses_float.data[0].embedding == decoded_responses_base64_data[
205-
0]
206-
assert responses_float.data[1].embedding == decoded_responses_base64_data[
207-
1]
205+
check_embeddings_close(
206+
embeddings_0_lst=float_data,
207+
embeddings_1_lst=base64_data,
208+
name_0="float",
209+
name_1="base64",
210+
)
208211

209212
# Default response is float32 decoded from base64 by OpenAI Client
210213
responses_default = await client.embeddings.create(input=input_texts,
211214
model=model_name)
215+
default_data = [d.embedding for d in responses_default.data]
212216

213-
assert responses_float.data[0].embedding == responses_default.data[
214-
0].embedding
215-
assert responses_float.data[1].embedding == responses_default.data[
216-
1].embedding
217+
check_embeddings_close(
218+
embeddings_0_lst=float_data,
219+
embeddings_1_lst=default_data,
220+
name_0="float",
221+
name_1="default",
222+
)
217223

218224

219225
@pytest.mark.asyncio

0 commit comments

Comments
 (0)