Skip to content

Commit b9b5bdf

Browse files
authored
[Misc] Catching Ray Compiled Graph PP test failures for V1 (#14847)
1 parent 31060b2 commit b9b5bdf

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

tests/distributed/test_pipeline_parallel.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,10 @@ def _compare_tp(
350350
else:
351351
pp_env = None
352352

353+
tp_env = {
354+
"VLLM_USE_V1": vllm_major_version,
355+
}
356+
353357
pp_args = [
354358
*common_args,
355359
"--pipeline-parallel-size",
@@ -374,14 +378,20 @@ def _compare_tp(
374378
]
375379

376380
try:
377-
compare_two_settings(model_id, pp_args, tp_args, pp_env, method=method)
381+
compare_two_settings(model_id,
382+
pp_args,
383+
tp_args,
384+
pp_env,
385+
tp_env,
386+
method=method)
378387
except Exception:
379-
if pp_env is None:
380-
raise
381-
else:
382-
# Ray Compiled Graph tests are flaky,
388+
testing_ray_compiled_graph = pp_env is not None
389+
if testing_ray_compiled_graph and vllm_major_version == "0":
390+
# Ray Compiled Graph tests are flaky for V0,
383391
# so we don't want to fail the test
384392
logger.exception("Ray Compiled Graph tests failed")
393+
else:
394+
raise
385395

386396

387397
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)