Skip to content

Commit c81259d

Browse files
authored
Fix/remove some broken model executor tests (#21224)
Signed-off-by: Rabi Mishra <[email protected]>
1 parent e3a0e43 commit c81259d

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

tests/model_executor/test_guided_processors.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -189,19 +189,6 @@ def test_multiple_guided_options_not_allowed(sample_json_schema, sample_regex):
189189
GuidedDecodingParams(json=sample_json_schema, grammar="test grammar")
190190

191191

192-
def test_guided_decoding_backend_options():
193-
"""Test backend-specific options"""
194-
with pytest.warns(DeprecationWarning):
195-
guided_decoding_params = GuidedDecodingParams(
196-
backend=
197-
"xgrammar:no-fallback,disable-any-whitespace,no-additional-properties"
198-
)
199-
assert guided_decoding_params.backend == "xgrammar"
200-
assert guided_decoding_params.disable_fallback
201-
assert guided_decoding_params.disable_any_whitespace
202-
assert guided_decoding_params.disable_additional_properties
203-
204-
205192
def test_pickle_xgrammar_tokenizer_data():
206193
try:
207194
import xgrammar as xgr

tests/model_executor/test_model_load_with_params.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_model_loading_with_params(vllm_runner):
4949

5050
def check_model(model):
5151
assert isinstance(model, BertEmbeddingModel)
52-
assert isinstance(model._pooler, CLSPool)
52+
assert isinstance(model.pooler.pooling, CLSPool)
5353

5454
vllm_model.apply_model(check_model)
5555

@@ -87,7 +87,7 @@ def test_roberta_model_loading_with_params(vllm_runner):
8787

8888
def check_model(model):
8989
assert isinstance(model, RobertaEmbeddingModel)
90-
assert isinstance(model._pooler, MeanPool)
90+
assert isinstance(model.pooler.pooling, MeanPool)
9191

9292
vllm_model.apply_model(check_model)
9393

@@ -114,7 +114,7 @@ def test_facebook_roberta_model_loading_with_params(vllm_runner):
114114
def check_model(model):
115115
assert isinstance(model, RobertaEmbeddingModel)
116116
assert not hasattr(model, "lm_head")
117-
assert isinstance(model._pooler, CLSPool)
117+
assert isinstance(model.pooler.pooling, CLSPool)
118118

119119
vllm_model.apply_model(check_model)
120120

0 commit comments

Comments
 (0)