Skip to content

Commit cce76df

Browse files
clean up some comments
Signed-off-by: jasonlizhengjian <[email protected]>
1 parent ed218fe commit cce76df

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

vllm/compilation/fp8_allgather_pass.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def __init__(self, config: VllmConfig):
132132
self.tp_size = get_tensor_model_parallel_world_size()
133133
if self.tp_size <= 1:
134134
self.disabled = True
135-
logger.info(
135+
logger.debug(
136136
"FP8 AllGather optimization disabled: TP size = %d "
137137
"(no communication needed)", self.tp_size)
138138
return
@@ -150,12 +150,12 @@ def __init__(self, config: VllmConfig):
150150
self.tp_size,
151151
self.tp_group_name,
152152
).register(self.patterns)
153-
logger.info(
153+
logger.debug(
154154
"FP8 AllGather optimization enabled: "
155155
"TP size = %d, dtype = %s", self.tp_size, self.model_dtype)
156156
else:
157157
self.disabled = True
158-
logger.info(
158+
logger.debug(
159159
"FP8 AllGather optimization disabled: "
160160
"model dtype = %s (requires BF16)", self.model_dtype)
161161

@@ -169,7 +169,7 @@ def __call__(self, graph: fx.Graph):
169169

170170
self.matched_count = self.patterns.apply(graph)
171171
if self.matched_count > 0:
172-
logger.info(
172+
logger.debug(
173173
"FP8 AllGather optimization: replaced %d AllGather "
174174
"operation(s) with FP8 quantized versions", self.matched_count)
175175
else:

vllm/compilation/pass_manager.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@ def configure(self, config: VllmConfig):
9292

9393
if self.pass_config.enable_sequence_parallelism:
9494
self.passes += [SequenceParallelismPass(config)]
95-
# FP8AllGatherOptPass must run BEFORE AsyncTPPass so that
96-
# AsyncTPPass can fuse vllm_all_gather_fp8 + ScaledMM
9795
if self.pass_config.enable_fp8_allgather_opt:
9896
self.passes += [FP8AllGatherOptPass(config)]
9997
if self.pass_config.enable_async_tp:

0 commit comments

Comments
 (0)