Fixed base_index calculation innefficiency

Author: astralord

vllm/entrypoints/openai/serving_chat.py

@@ -734,6 +734,15 @@ async def chat_completion_stream_generator(
                         combined_reasoning = ""
                         tool_messages = []
 
+                        # Calculate base_index once before the loop
+                        base_index = 0
+                        for msg in harmony_parser.messages:
+                            if (msg.channel == "commentary"
+                                    and msg.recipient
+                                    and msg.recipient.startswith(
+                                        "functions.")):
+                                base_index += 1
+
                         for group in groups:
                             group_channel = group['channel']
                             group_recipient = group['recipient']
@@ -747,14 +756,6 @@ async def chat_completion_stream_generator(
                             elif (group_channel == "commentary" and group_recipient
                                   and group_recipient.startswith("functions.")):
 
-                                base_index = 0
-                                for msg in harmony_parser.messages:
-                                    if (msg.channel == "commentary"
-                                            and msg.recipient
-                                            and msg.recipient.startswith(
-                                                "functions.")):
-                                        base_index += 1
-
                                 if prev_recipient != group_recipient:
                                     tool_name = group_recipient.split(
                                         "functions.", 1)[1]
@@ -768,10 +769,12 @@ async def chat_completion_stream_generator(
                                         index=base_index,
                                     ))
                                     prev_recipient = group_recipient
+                                    # Increment index for next tool call
+                                    base_index += 1
 
                                 if group_text:
                                     tool_messages.append(DeltaToolCall(
-                                        index=base_index,
+                                        index=base_index - 1,  # Use the index of the current tool call
                                         function=DeltaFunctionCall(
                                             arguments=group_text),
                                     ))