Skip to content

Commit e5ebeeb

Browse files
authored
Remove exception for Python 3.8 typing from linter (#22506)
Signed-off-by: Harry Mellor <[email protected]>
1 parent 7be7f38 commit e5ebeeb

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ line-length = 80
7373
"vllm/engine/**/*.py" = ["UP006", "UP035"]
7474
"vllm/executor/**/*.py" = ["UP006", "UP035"]
7575
"vllm/worker/**/*.py" = ["UP006", "UP035"]
76-
# Python 3.8 typing - skip utils for ROCm
77-
"vllm/utils/__init__.py" = ["UP006", "UP035"]
7876

7977
[tool.ruff.lint]
8078
select = [

vllm/utils/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
from functools import cache, lru_cache, partial, wraps
4848
from types import MappingProxyType
4949
from typing import (TYPE_CHECKING, Any, Callable, Generic, Literal, NamedTuple,
50-
Optional, TextIO, Tuple, TypeVar, Union, cast, overload)
50+
Optional, TextIO, TypeVar, Union, cast, overload)
5151
from urllib.parse import urlparse
5252
from uuid import uuid4
5353

@@ -861,7 +861,7 @@ def is_valid_ipv6_address(address: str) -> bool:
861861
return False
862862

863863

864-
def split_host_port(host_port: str) -> Tuple[str, int]:
864+
def split_host_port(host_port: str) -> tuple[str, int]:
865865
# ipv6
866866
if host_port.startswith('['):
867867
host, port = host_port.rsplit(']', 1)

0 commit comments

Comments
 (0)