Skip to content

[Deprecation] Remove deprecated args and methods #21907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 31, 2025
Merged

[Deprecation] Remove deprecated args and methods #21907

merged 6 commits into from
Jul 31, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 30, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
@mergify mergify bot added frontend multi-modality Related to multi-modality (#4194) labels Jul 30, 2025
@DarkLight1337
Reduce diff
e5d0015 
Signed-off-by: DarkLight1337 <[email protected]>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on removing deprecated arguments and methods, which is a great step for improving code clarity and maintainability. The changes are consistent across the affected files.

Specifically:

  • The removal of the @deprecate_kwargs decorator and the trust_remote_code argument from several functions in vllm/entrypoints/chat_utils.py is correctly handled, as the code now relies on model_config.trust_remote_code.
  • The simplification in BaseMultiModalItemTracker.add is correct, as the removed else branch was effectively dead code since has_processor always returned True.
  • The removal of deprecated methods (create_input_mapper, init_mm_limits_per_prompt, has_processor) from vllm/multimodal/registry.py and their corresponding usages in other files is clean and consistent.

Overall, the changes are well-executed and I don't see any issues. This is a solid cleanup effort.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 31, 2025
@DarkLight1337
Test passes
78ecd66 
Signed-off-by: DarkLight1337 <[email protected]>
@vllm-bot vllm-bot merged commit 9532a6d into vllm-project:main Jul 31, 2025
3 of 6 checks passed
@DarkLight1337 DarkLight1337 deleted the deprecate-v0.11 branch July 31, 2025 06:46
@elvischenv elvischenv mentioned this pull request Aug 1, 2025
Closed
vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
@DarkLight1337 @vadiklyutiy
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
b6f5eb9 
Signed-off-by: DarkLight1337 <[email protected]>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@DarkLight1337 @x22x22
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
6967d0e 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: x22x22 <[email protected]>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@DarkLight1337 @npanpaliya
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
d84a85e 
Signed-off-by: DarkLight1337 <[email protected]>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@DarkLight1337 @jinzhen-lin
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
d60a58f 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@DarkLight1337 @noamgat
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
4162485 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @paulpak58
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
49360e8 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@DarkLight1337 @diegocastanibm
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
f3e081a 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @epwalsh
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
5d193dd 
Signed-off-by: DarkLight1337 <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @zhewenl
[Deprecation] Remove deprecated args and methods (vllm-project#21907)
88198e1 
Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build frontend multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot