Skip to content

[Model] Use merge_by_field_config for MM models (Ovis family) #26308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 7, 2025
Merged

[Model] Use merge_by_field_config for MM models (Ovis family) #26308

merged 10 commits into from
Oct 7, 2025

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Oct 6, 2025 •
edited by github-actions bot
Loading

Purpose

  • Fix broken Ovis2/Ovis2.5 examples
  • Update Ovis2.5 VideoPatchInputs to use TensorSchema
  • Use merge_by_field_config for Ovis families

Test Plan

python examples/offline_inference/vision_language.py -m ovis2

python examples/offline_inference/vision_language.py -m ovis2_5

Test Result

Have confirmed examples and tests/models/multimodal/generation/test_common.py worked.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 6, 2025
@DarkLight1337 DarkLight1337 mentioned this pull request Oct 6, 2025
Open
12 tasks
@Isotr0py
update ovis2.5 video schema
42b52a6 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix image inference
765d8b8 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix ovis2
665c897 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py changed the title [Model] Use merge_by_field_config for Ovis families [Model] Use merge_by_field_config for MM models (Ovis family) Oct 7, 2025
@Isotr0py Isotr0py marked this pull request as ready for review October 7, 2025 08:21
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Oct 7, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@Isotr0py
fix missing grids
1ac3239 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py requested a review from DarkLight1337 October 7, 2025 09:00
DarkLight1337
DarkLight1337 reviewed Oct 7, 2025
View reviewed changes
@Isotr0py
correct name
85c832d 
Signed-off-by: Isotr0py <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 7, 2025 11:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 7, 2025
@DarkLight1337 DarkLight1337 merged commit 08d26a1 into vllm-project:main Oct 7, 2025
55 checks passed
@Isotr0py Isotr0py deleted the fix-ovis2 branch October 7, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @DarkLight1337