Skip to content

Commit 3701cf1

Browse files
committed
Migrate tests away from MockTestcontainersConfigurationRule
1 parent d838eb0 commit 3701cf1

File tree

5 files changed

+10
-65
lines changed

5 files changed

+10
-65
lines changed

core/src/test/java/org/testcontainers/DockerClientFactoryTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,20 @@
11
package org.testcontainers;
22

33
import org.junit.jupiter.api.Test;
4+
import org.junit.jupiter.api.extension.ExtendWith;
45
import org.testcontainers.dockerclient.LogToStringContainerCallback;
5-
import org.testcontainers.junit.jupiter.Container;
6-
import org.testcontainers.junit.jupiter.Testcontainers;
76
import org.testcontainers.utility.DockerImageName;
8-
import org.testcontainers.utility.MockTestcontainersConfigurationRule;
7+
import org.testcontainers.utility.MockTestcontainersConfigurationExtension;
98

109
import static org.assertj.core.api.Assertions.assertThat;
1110
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1211

1312
/**
1413
* Test for {@link DockerClientFactory}.
1514
*/
16-
@Testcontainers
15+
@ExtendWith(MockTestcontainersConfigurationExtension.class)
1716
public class DockerClientFactoryTest {
1817

19-
@Container
20-
public MockTestcontainersConfigurationRule configurationMock = new MockTestcontainersConfigurationRule();
21-
2218
@Test
2319
public void runCommandInsideDockerShouldNotFailIfImageDoesNotExistsLocally() {
2420
try (DockerRegistryContainer registryContainer = new DockerRegistryContainer()) {

core/src/test/java/org/testcontainers/images/OverrideImagePullPolicyTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,19 @@
33
import org.junit.jupiter.api.AfterEach;
44
import org.junit.jupiter.api.BeforeEach;
55
import org.junit.jupiter.api.Test;
6+
import org.junit.jupiter.api.extension.ExtendWith;
67
import org.mockito.Mockito;
78
import org.testcontainers.DockerRegistryContainer;
89
import org.testcontainers.containers.GenericContainer;
9-
import org.testcontainers.junit.jupiter.Container;
10-
import org.testcontainers.junit.jupiter.Testcontainers;
1110
import org.testcontainers.utility.FakeImagePullPolicy;
12-
import org.testcontainers.utility.MockTestcontainersConfigurationRule;
11+
import org.testcontainers.utility.MockTestcontainersConfigurationExtension;
1312
import org.testcontainers.utility.TestcontainersConfiguration;
1413

1514
import static org.assertj.core.api.Assertions.assertThat;
1615

17-
@Testcontainers
16+
@ExtendWith(MockTestcontainersConfigurationExtension.class)
1817
public class OverrideImagePullPolicyTest {
1918

20-
@Container
21-
public MockTestcontainersConfigurationRule config = new MockTestcontainersConfigurationRule();
22-
2319
private ImagePullPolicy originalInstance;
2420

2521
private ImagePullPolicy originalDefaultImplementation;

core/src/test/java/org/testcontainers/utility/DefaultImageNameSubstitutorTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22

33
import org.junit.jupiter.api.BeforeEach;
44
import org.junit.jupiter.api.Test;
5+
import org.junit.jupiter.api.extension.ExtendWith;
56
import org.mockito.Mockito;
6-
import org.testcontainers.junit.jupiter.Container;
7-
import org.testcontainers.junit.jupiter.Testcontainers;
87

98
import static org.assertj.core.api.Assertions.assertThat;
109
import static org.mockito.ArgumentMatchers.eq;
1110

12-
@Testcontainers
11+
@ExtendWith(MockTestcontainersConfigurationExtension.class)
1312
public class DefaultImageNameSubstitutorTest {
1413

1514
public static final DockerImageName ORIGINAL_IMAGE = DockerImageName.parse("foo");
@@ -18,9 +17,6 @@ public class DefaultImageNameSubstitutorTest {
1817

1918
private ConfigurationFileImageNameSubstitutor underTest;
2019

21-
@Container
22-
public MockTestcontainersConfigurationRule config = new MockTestcontainersConfigurationRule();
23-
2420
@BeforeEach
2521
public void setUp() {
2622
underTest = new ConfigurationFileImageNameSubstitutor(TestcontainersConfiguration.getInstance());

core/src/test/java/org/testcontainers/utility/ImageNameSubstitutorTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
import org.junit.jupiter.api.AfterEach;
44
import org.junit.jupiter.api.BeforeEach;
55
import org.junit.jupiter.api.Test;
6+
import org.junit.jupiter.api.extension.ExtendWith;
67
import org.junit.jupiter.api.io.TempDir;
78
import org.mockito.Mockito;
89
import org.testcontainers.containers.GenericContainer;
9-
import org.testcontainers.junit.jupiter.Container;
10-
import org.testcontainers.junit.jupiter.Testcontainers;
1110

1211
import java.io.FileWriter;
1312
import java.io.IOException;
@@ -21,15 +20,12 @@
2120
import static org.assertj.core.api.Assertions.assertThatThrownBy;
2221
import static org.mockito.ArgumentMatchers.eq;
2322

24-
@Testcontainers
23+
@ExtendWith(MockTestcontainersConfigurationExtension.class)
2524
public class ImageNameSubstitutorTest {
2625

2726
@TempDir
2827
public Path tempFolder;
2928

30-
@Container
31-
public MockTestcontainersConfigurationRule config = new MockTestcontainersConfigurationRule();
32-
3329
private ImageNameSubstitutor originalInstance;
3430

3531
private ImageNameSubstitutor originalDefaultImplementation;

core/src/test/java/org/testcontainers/utility/MockTestcontainersConfigurationRule.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

0 commit comments

Comments
 (0)