spa refactor #12
Draft
spa refactor #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer writes the `index.html` file to the results dir
darcyclarke
force-pushed
the
ejkorol/benchmark-spa-refactor
branch
2 times, most recently
from
6a851f1 to
e091123
Compare
Notes:
|
- remove unnecessarry nested results dir in charts - add static files to charts dir - change date header - pull in dynamic date from constants - update vit config to output to charts dir - update package count script to output to charts dir - update process results script to output to charts dir - update benchmark script to output to charts dir
darcyclarke
force-pushed
the
ejkorol/benchmark-spa-refactor
branch
from
e091123 to
5840211
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing static HTML chart generation with a modern React SPA (Single Page Application) for displaying benchmark results, improving the user experience for viewing and interacting with benchmark data.
Key Changes
- Replaces Chart.js-based static HTML generation with a React/TypeScript SPA
- Implements interactive charts using Recharts library with filtering and sorting capabilities
- Updates build pipeline to use Vite and generates results to
charts/directory instead of static HTML files
Reviewed Changes
Copilot reviewed 45 out of 69 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds React, Vite, and charting dependencies for the new SPA |
src/ (multiple files) |
Creates complete React application with components, hooks, and utilities |
scripts/generate-chart.js |
Converts from HTML generation to JSON data output for SPA consumption |
scripts/process-results.sh |
Updates file paths and removes HTML copying logic |
vite.config.ts |
Configures Vite build system for the React application |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates how the benchmark html files are serves and replaces the old method of serving the built html files with a react spa.