Loader: use isset instead of strpbrk (#223)

jrchamp · GrahamCampbell · commit 7ac2c1cef304 · 2017-02-03T22:05:04.000Z
diff --git a/src/Loader.php b/src/Loader.php
@@ -312,7 +312,7 @@ protected function sanitiseVariableName($name, $value)
      */
     protected function beginsWithAQuote($value)
     {
-        return strpbrk($value[0], '"\'') !== false;
+        return isset($value[0]) && ($value[0] === '"' || $value[0] === '\'');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ protected function sanitiseVariableName($name, $value)`
`312`	`312`	`*/`
`313`	`313`	`protected function beginsWithAQuote($value)`
`314`	`314`	`{`
`315`		`- return strpbrk($value[0], '"\'') !== false;`
	`315`	`+ return isset($value[0]) && ($value[0] === '"' \|\| $value[0] === '\'');`
`316`	`316`	`}`
`317`	`317`
`318`	`318`	`/**`